fix(preprod): Use project ID instead of slug in legacy URL redirects #106859
+134
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
When legacy preprod URLs (format: /preprod/{slug}/{artifactId}/) are
accessed, the redirect now converts the project slug to its numeric
project ID before constructing the new URL format with query parameters.
This ensures consistency with the rest of the application which expects
numeric project IDs in the ?project= query parameter, not slugs.
Changes:
- Modified LegacyPreprodRedirect to use useProjectFromSlug hook
- Waits for project data to load before redirecting
- Converts slug to numeric ID for all redirect scenarios (size, compare, install)
- Added comprehensive tests for redirect behavior
runningcode
force-pushed
the
no/fix-preprod-legacy-redirect-project-id
branch
from
841529d to
b7a8d72
Compare
The route parameter is named 'projectId' but actually contains a project slug from the legacy URL format. Added explicit variable naming and comments to make this clear: - Renamed local variable to 'projectSlugFromUrl' to reflect actual content - Added inline comment explaining the route param misnaming - Updated comment to clarify we prefer numeric ID, fallback to slug This makes the code's intent much clearer without changing behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes legacy preprod URL redirects to use numeric project IDs instead of project slugs in the query parameter, with fallback to slug for backward compatibility.
Problem
When users access legacy preprod URLs in the format
/preprod/{projectSlug}/{artifactId}/, the redirect was passing the project slug directly to the?project=query parameter. However, the rest of the application expects numeric project IDs in this parameter for consistency and stability (project IDs don't change, slugs can).Solution
LegacyPreprodRedirectcomponent to useuseProjectFromSlughook to fetch the full project objectBehavior
When project is found:
When project is not found (fallback):
This maintains backward compatibility and ensures users are never stuck on the legacy URL.
Testing
Added comprehensive test coverage in
legacyUrlRedirect.spec.tsxcovering: