-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
feat(preprod): Add mobile builds onboarding with platform-specific instructions (EME-733) #106856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
runningcode
wants to merge
7
commits into
master
Choose a base branch
from
no/eme-733-mobile-builds-onboarding
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…structions (EME-733) Replace simple "No mobile builds found" message with rich onboarding experience showing platform-specific setup instructions (Fastlane for iOS, Gradle for Android) using guided steps. - Create PreprodBuildsOnboarding component with platform detection - Add guided steps navigation with URL-based step tracking - Include code examples and documentation links for each platform - Add analytics events for onboarding interactions - Show onboarding only for single project selection with no search query - Preserve "no results" state when search is active
Replace complex guided steps with simpler panel matching Size Analysis onboarding style. Extract shared UI into PreprodOnboardingPanel component. Changes: - Extract shared onboarding UI into preprodOnboardingPanel.tsx - Simplify preprodBuildsOnboarding.tsx (135 lines → 41 lines) - Update preprodOnboarding.tsx to use shared component (109 lines → 14 lines) - Add Flutter and React Native documentation links - Add illustration to mobile builds onboarding - Fix theme property access (familyMono → font.family.mono, fontSize.sm → font.size.sm) Both onboardings now show: - Heading and description - 3 bullet points of benefits - Product docs + platform-specific docs (iOS, Android, Flutter, React Native) - Illustration on right side (hidden on mobile)
…(EME-733) - Update link_type to use platform names: 'product', 'ios', 'android', 'flutter', 'react-native' - Remove unused step_completed event (guided steps removed) - Fixes TypeScript error in preprodBuildsOnboarding.tsx
runningcode
commented
Jan 23, 2026
| @@ -0,0 +1,116 @@ | |||
| import {useTheme} from '@emotion/react'; | |||
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is mostly just moved over from static/app/views/releases/detail/commitsAndFiles/preprodOnboarding.tsx
so we can re-use it
…EME-733) Remove unnecessary PreprodBuildsOnboarding wrapper component and handle analytics tracking directly in mobileBuilds.tsx. Clean up unused props from PreprodOnboarding component and improve conditional rendering safety.
…y state (EME-733)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace the "No mobile builds found" message with platform-specific documentation links (iOS, Android, Flutter, React Native).
After:

This is the same was what existed before when you went to the releases page and there were no builds uploaded for a given release. Now the code for both is consolidated.
Related