ref(seer): cleanup unused spans rpc #106854
Conversation
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| from sentry.utils.dates import parse_stats_period | ||
| from sentry.utils.env import in_test_environment | ||
| from sentry.utils.seer import can_use_prevent_ai_features | ||
| from sentry.utils.snuba_rpc import table_rpc |
There was a problem hiding this comment.
Unused TypedDict classes after function removal
Low Severity
The ColumnDict, SortDict, and SpansResponse TypedDict classes remain defined but are now unused after the removal of get_spans, which was their only consumer. These classes were type hints for the removed function and its parameters, and should be removed as part of this cleanup to avoid cluttering the codebase with dead code.
| "meta": { | ||
| "columns": columns, | ||
| "total_rows": len(parsed_data), | ||
| }, |
There was a problem hiding this comment.
Orphaned tests for removed function
Medium Severity
The removal of get_spans and related functions leaves behind five test methods in tests/snuba/api/endpoints/test_seer_attributes.py that test this now-deleted functionality. The test file imports get_spans on line 8 and has test methods test_get_spans_basic, test_get_spans_with_query, test_get_spans_with_sort, test_get_spans_invalid_stats_period, and test_get_spans_empty_response that will fail. This incomplete cleanup contradicts the PR's stated goal of cleaning up unused code and leaves dead test code in the codebase.
Not called in seer, deprecated in favor of execute_table_query