ref(explorer): refactor rpc date param validation

[aliu39]

instead of branching to our own util to parse and validate start end statsPeriod, lean on the existing sentry api validation and util.

Changes:

• When invoking an endpoint, directly pass the params to it (already has validation)
• When passing date params for other use, use get_date_range_from_params
• Adds a get_group_date_range convenience util for getting a group's first/last seen time range, clamped by retention.
• Updates the baselines rpc for suspect tags to default to the first/last seen range instead of last 7d. This matches the behavior of the issue tool when no date is specified

Note: I removed some default stats periods from explorer tools, as it seems better to maintain and pass them from seer only. Right now Seer mostly defaults to passing 7d, so the sentry-side defaults aren't used

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.}

[cursor]

Default time period increased from 7d to 90d

Medium Severity

In get_attributes_and_values, the default time period changed from 7 days to 90 days when no date parameters are provided. The old validate_date_params defaulted to "7d" while get_date_range_from_params defaults to MAX_STATS_PERIOD (90 days). This 13x increase could cause performance issues and significantly higher query costs if callers don't explicitly pass date params. While the PR notes Seer "mostly" passes 7d, the word "mostly" suggests edge cases exist where params aren't provided.

 

[aliu39]

only callsite in seer uses 6h: https://github.com/getsentry/seer/blob/972de32e3ee8bfc797409e7a48b968e370e318c8/src/seer/automation/assisted_query/create_cache.py#L49-L55

[roaga]

would double check that seer passes in the defaults as needed for all our tools

also does this impact any functionality or is this just cleanup?

[aliu39]

@roaga I've double checked the defaults I've removed here are passed with a default (sometimes different) from seer. Will comment on those functions here

This is mostly cleanup, but the changes are removed defaults (doesnt change functionality, only future use of rpcs) + defaulting to issue lifetime for the baselines rpc

[aliu39]

also baseline rpc will raise now if the group doesn't exist