chore(preprod): Add approve action into github status check for size #106852
+81
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
Scope: Backend
NicoHinderling
force-pushed
the
01-22-chore_preprod_add_github_webhook_handler_for_size_approve_action
branch
from
1390e38 to
1b9592a
Compare
NicoHinderling
force-pushed
the
01-22-chore_preprod_add_approve_action_into_github_status_check_for_size
branch
from
615b1f2 to
a612f47
Compare
NicoHinderling
force-pushed
the
01-22-chore_preprod_add_approve_action_into_github_status_check_for_size
branch
from
a612f47 to
cd2e8cc
Compare
NicoHinderling
commented
Jan 23, 2026
| if triggered_rules: | ||
| failed_artifact_ids = {tr.artifact_id for tr in triggered_rules} | ||
| failed_artifacts = [a for a in artifacts if a.id in failed_artifact_ids] | ||
| passed_artifacts = [a for a in artifacts if a.id not in failed_artifact_ids] |
Contributor
Author
There was a problem hiding this comment.
FYI @mtopo27 is planning to do some more UI cleanup to our status checks but I was doing some testing and mostly made changes to make sure the current UI at least makes sense (no redundant titles, the # above the table matches the number of rows in the table, etc)
NicoHinderling
force-pushed
the
01-22-chore_preprod_add_approve_action_into_github_status_check_for_size
branch
from
cd2e8cc to
cc51a1f
Compare
NicoHinderling
force-pushed
the
01-22-chore_preprod_add_github_webhook_handler_for_size_approve_action
branch
from
668e3b2 to
f8dc4af
Compare
NicoHinderling
force-pushed
the
01-22-chore_preprod_add_github_webhook_handler_for_size_approve_action
branch
from
d41d978 to
4e90e3c
Compare
NicoHinderling
force-pushed
the
01-22-chore_preprod_add_approve_action_into_github_status_check_for_size
branch
from
cc51a1f to
84f1ad1
Compare
NicoHinderling
force-pushed
the
01-22-chore_preprod_add_approve_action_into_github_status_check_for_size
branch
from
84f1ad1 to
9163387
Compare
NicoHinderling
force-pushed
the
01-22-chore_preprod_add_github_webhook_handler_for_size_approve_action
branch
from
4e90e3c to
3a9ab9f
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before approval (note "approve" button):
After approval and refresh that is subsequently triggered:
