Skip to content

Conversation

@JonasBa
Copy link
Member

@JonasBa JonasBa commented Jan 22, 2026

Applies the flex codemod to files owned by @getsentry/alerts-create-issues.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 22, 2026
@JonasBa JonasBa marked this pull request as ready for review January 22, 2026 23:09
@JonasBa JonasBa requested a review from a team as a code owner January 22, 2026 23:09
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

<Container marginBottom="2xl">
<HeaderTitleLegend>{t('Alerts Triggered')}</HeaderTitleLegend>
</ChartHeader>
</Container>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spacing value changed from 20px to 24px

Low Severity

The codemod changed the chart header's bottom margin from space(3) (20px) to marginBottom="2xl" (24px), a 4px increase. While this may be intentional as part of the design system migration, the PR description doesn't mention visual changes, and this spacing difference could unintentionally affect the chart's layout.

Fix in Cursor Fix in Web

@@ -1,4 +1,4 @@
import styled from '@emotion/styled';
import {Container} from '@sentry/scraps/layout';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent import paths for Container component

Low Severity

The codemod introduces Container imports using @sentry/scraps/layout in email.tsx and assignedTo.tsx, but the majority of files in views/automations (7 of 11 files) use sentry/components/core/layout for layout imports. Sibling files like discord.tsx and slack.tsx use sentry/components/core/layout, creating an inconsistent import pattern that reduces code maintainability.

Additional Locations (1)

Fix in Cursor Fix in Web

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants