Skip to content

Conversation

@JonasBa
Copy link
Member

@JonasBa JonasBa commented Jan 22, 2026

Applies the flex codemod to files owned by @getsentry/replay-frontend.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 22, 2026
@JonasBa JonasBa marked this pull request as ready for review January 22, 2026 23:09
@JonasBa JonasBa requested a review from a team as a code owner January 22, 2026 23:09
Copy link
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 3 potential issues.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

`;
export function OverflowHidden(props: ContainerProps<'div'>) {
return <Container height="100%" overflow="hidden" position="relative" {...props} />;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing display grid in OverflowHidden component

High Severity

The OverflowHidden component is missing display="grid" in its conversion from a styled component. The original styled component had display: grid which is critical for the layout to work correctly with AutoSizer and MultiGrid components that depend on this grid layout.

Fix in Cursor Fix in Web

{...props}
/>
);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing display grid in SplitPanel component

High Severity

The SplitPanel component is missing display="grid" in its conversion from a styled component. The original had display: grid which is essential because the component is used with gridTemplateRows style prop in network/index.tsx, and grid template properties only work when display is set to grid.

Fix in Cursor Fix in Web

<ErrorTable data-test-id="replay-details-errors-tab">
{errorFrames ? (
<OverflowHidden>
<Container height="100%" overflow="hidden" position="relative">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing display grid in errorList Container

High Severity

The Container replacement for the removed OverflowHidden styled component is missing display="grid" property. The original styled component had display: grid which is required for the AutoSizer and MultiGrid layout to function correctly.

Fix in Cursor Fix in Web

Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a glance those Bugbot complaints look legitimate, otherwise this LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants