-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
codemod(flex): apply changes for @getsentry/replay-frontend #106837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 3 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| `; | ||
| export function OverflowHidden(props: ContainerProps<'div'>) { | ||
| return <Container height="100%" overflow="hidden" position="relative" {...props} />; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing display grid in OverflowHidden component
High Severity
The OverflowHidden component is missing display="grid" in its conversion from a styled component. The original styled component had display: grid which is critical for the layout to work correctly with AutoSizer and MultiGrid components that depend on this grid layout.
| {...props} | ||
| /> | ||
| ); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing display grid in SplitPanel component
High Severity
The SplitPanel component is missing display="grid" in its conversion from a styled component. The original had display: grid which is essential because the component is used with gridTemplateRows style prop in network/index.tsx, and grid template properties only work when display is set to grid.
| <ErrorTable data-test-id="replay-details-errors-tab"> | ||
| {errorFrames ? ( | ||
| <OverflowHidden> | ||
| <Container height="100%" overflow="hidden" position="relative"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gggritso
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a glance those Bugbot complaints look legitimate, otherwise this LGTM!
Applies the flex codemod to files owned by @getsentry/replay-frontend.