feat(uptime-assertion-in-checks): Adding assertion_failure_data to the eap_converter #106833
+58
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 22, 2026 17:18
github-actions
bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
wedamija
reviewed
Jan 22, 2026
| attributes["status_reason_type"] = _anyvalue(status_reason["type"]) | ||
| attributes["status_reason_description"] = _anyvalue(status_reason["description"]) | ||
|
|
||
| assertion_failure_data = result["assertion_failure_data"] |
Member
There was a problem hiding this comment.
I think that the bots are right and it'd be safer to use .get() here
Contributor
Author
There was a problem hiding this comment.
Oh sorry @wedamija, this was supposed to be a draft.
Ready for review now, pushed the rest of the changes, fixed the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shoul let us query for the column from the eap trace_item table