Skip to content

Conversation

@seer-by-sentry
Copy link
Contributor

@seer-by-sentry seer-by-sentry bot commented Jan 22, 2026

This PR addresses the TypeError: Cannot read properties of undefined (reading 'series') occurring in releasesDrawerList.tsx.

Root Cause: The error stemmed from a race condition where echartsInstance.getOption() would return undefined (or series or markLine.data would be unavailable) when the ECharts chart was in a transitional state, such as during loading, unmounting, or re-rendering. This often happened when mouse events (like onMouseOutRelease) were triggered while the chart was not fully initialized or was being disposed.

Solution: Defensive null checks have been added within the createMarkLineUpdater function. Specifically, the code now checks if echartsInstance.getOption() returns a valid options object, and subsequently, if the series and markLine.data properties exist before attempting to access them. This prevents the TypeError by gracefully handling scenarios where the chart's state is not yet ready or is being torn down.

Closes JAVASCRIPT-33FS

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jan 22, 2026
@Zylphrex Zylphrex self-assigned this Jan 22, 2026
@Zylphrex Zylphrex added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jan 22, 2026
@Zylphrex Zylphrex marked this pull request as ready for review January 22, 2026 22:39
@Zylphrex Zylphrex requested a review from a team as a code owner January 22, 2026 22:39
@Zylphrex Zylphrex merged commit 1219241 into master Jan 23, 2026
56 of 57 checks passed
@Zylphrex Zylphrex deleted the seer/fix-javascript-33fs-echarts-null-check branch January 23, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants