Skip to content

Conversation

@JoshFerge
Copy link
Member

@JoshFerge JoshFerge commented Dec 9, 2025

Implements AIML-2003

Adds thumbs up/down feedback buttons directly in the Seer Root Cause, Solution, and Code Changes cards to collect user feedback.

Changes

  • Created CardFeedback Component:

    • Displays thumbs up/down icons for each card
    • Tracks the existing seer.autofix.feedback_submitted analytics event
    • Shows "Thanks!" message after feedback is submitted
    • Prevents event propagation to avoid interfering with card navigation
  • Integrated Into Summary Cards:

    • Feedback buttons appear in card headers between title and copy button
    • Only shown when card is fully loaded and has a valid run_id
    • Supports all three card types: Root Cause, Solution, and Code Changes
  • Comprehensive Test Coverage:

    • 9 tests covering all feedback scenarios
    • Validates analytics event tracking with correct parameters
    • Tests loading states and edge cases

This reuses the existing seer.autofix.feedback_submitted analytics event (no backend changes needed).

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Co-authored-by: josh.ferge <josh.ferge@sentry.io>
@cursor
Copy link
Contributor

cursor bot commented Dec 9, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Dec 9, 2025
@codecov
Copy link

codecov bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #104569      +/-   ##
===========================================
- Coverage   80.63%    80.52%   -0.12%     
===========================================
  Files        9335      9330       -5     
  Lines      402949    400651    -2298     
  Branches    25689     25689              
===========================================
- Hits       324921    322621    -2300     
- Misses      77562     77564       +2     
  Partials      466       466              

@JoshFerge JoshFerge changed the title Implement seer context panel feat: Add thumbs up/down feedback to Seer cards Dec 9, 2025
- Remove unused project variable
- Remove async keyword from tests without await
- Fix TypeScript errors with render options (user not supported)
- Add proper type guards for array indexing
- Use ConfigStore to set user in tests
- Remove duplicated CardFeedback component
- Add buttonSize, compact, and onFeedbackClick props to AutofixStepFeedback
- Use AutofixStepFeedback in both seer context panel and summary cards
- Both now use the same analytics event: 'seer.autofix.feedback_submitted'
- Reduces code duplication and ensures consistency
@JoshFerge JoshFerge marked this pull request as ready for review December 9, 2025 19:50
@JoshFerge JoshFerge requested a review from a team as a code owner December 9, 2025 19:50
@JoshFerge JoshFerge merged commit 5b14b7c into master Dec 9, 2025
49 checks passed
@JoshFerge JoshFerge deleted the cursor/implement-seer-context-panel-966a branch December 9, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants