fix(types): Use checked arithmetic in envelope parsing#1122
Open
szokeasaurusrex wants to merge 1 commit intomasterfrom
Open
fix(types): Use checked arithmetic in envelope parsing#1122szokeasaurusrex wants to merge 1 commit intomasterfrom
szokeasaurusrex wants to merge 1 commit intomasterfrom
Conversation
lcian
reviewed
May 7, 2026
lcian
reviewed
May 7, 2026
Replace unchecked envelope parser offset arithmetic with checked operations and document the invariants that make each addition safe. This removes the file-level lint exception while keeping malformed envelope handling explicit. Closes #1118 Closes [RUST-214](https://linear.app/getsentry/issue/RUST-214/fix-checked-arithmetic-in-sentry-typessrcprotocolenvelopers)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/checked-arithmetic-envelope
branch
from
ccb12cd to
0889e82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace unchecked envelope parser offset arithmetic with checked operations and document the invariants that make each addition safe. This removes the file-level lint exception while keeping malformed envelope handling explicit.
Stacked on #1119
Closes #1118
Closes RUST-214