-
-
Notifications
You must be signed in to change notification settings - Fork 359
Add expoUpdatesListenerIntegration that records breadcrumbs for Expo Updates lifecycle events
#5795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,6 +19,7 @@ import { | |
| eventOriginIntegration, | ||
| expoConstantsIntegration, | ||
| expoContextIntegration, | ||
| expoUpdatesListenerIntegration, | ||
| functionToStringIntegration, | ||
| hermesProfilingIntegration, | ||
| httpClientIntegration, | ||
|
|
@@ -133,6 +134,7 @@ export function getDefaultIntegrations(options: ReactNativeClientOptions): Integ | |
|
|
||
| integrations.push(expoContextIntegration()); | ||
| integrations.push(expoConstantsIntegration()); | ||
| integrations.push(expoUpdatesListenerIntegration()); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. m: I was wondering if we should add an option for this and not always add the integration unconditionally. Since this adds a listener it might add overhead and users might not always want to enable.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We could add it by default on the next major, what do you think? |
||
|
|
||
| if (options.spotlight && __DEV__) { | ||
| const sidecarUrl = typeof options.spotlight === 'string' ? options.spotlight : undefined; | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,158 @@ | ||
| import { addBreadcrumb, debug, type Integration, type SeverityLevel } from '@sentry/core'; | ||
| import type { ReactNativeClient } from '../client'; | ||
| import { isExpo, isExpoGo } from '../utils/environment'; | ||
|
|
||
| const INTEGRATION_NAME = 'ExpoUpdatesListener'; | ||
|
|
||
| const BREADCRUMB_CATEGORY = 'expo.updates'; | ||
|
|
||
| /** | ||
| * Describes the state machine context from `expo-updates`. | ||
| * We define our own minimal type to avoid a hard dependency on `expo-updates`. | ||
| */ | ||
| interface UpdatesNativeStateMachineContext { | ||
| isChecking: boolean; | ||
| isDownloading: boolean; | ||
| isUpdateAvailable: boolean; | ||
| isUpdatePending: boolean; | ||
| isRestarting: boolean; | ||
| latestManifest?: { id?: string }; | ||
| downloadedManifest?: { id?: string }; | ||
| rollback?: { commitTime: string }; | ||
| checkError?: Error; | ||
| downloadError?: Error; | ||
| } | ||
|
|
||
| interface UpdatesNativeStateChangeEvent { | ||
| context: UpdatesNativeStateMachineContext; | ||
| } | ||
|
|
||
| /** | ||
| * Tries to load `expo-updates` and retrieve `addUpdatesStateChangeListener`. | ||
| * Returns `undefined` if `expo-updates` is not installed. | ||
| */ | ||
| function getAddUpdatesStateChangeListener(): | ||
| | ((listener: (event: UpdatesNativeStateChangeEvent) => void) => void) | ||
| | undefined { | ||
| try { | ||
| // eslint-disable-next-line @typescript-eslint/no-var-requires,@typescript-eslint/no-unsafe-member-access | ||
| const addListener = require('expo-updates').addUpdatesStateChangeListener; | ||
| if (typeof addListener === 'function') { | ||
| return addListener as (listener: (event: UpdatesNativeStateChangeEvent) => void) => void; | ||
| } | ||
| } catch (_) { | ||
| // that happens when expo-updates is not installed | ||
| } | ||
| return undefined; | ||
| } | ||
|
|
||
| interface StateTransition { | ||
| field: keyof UpdatesNativeStateMachineContext; | ||
| message: string; | ||
| level: SeverityLevel; | ||
| getData?: (ctx: UpdatesNativeStateMachineContext) => Record<string, unknown> | undefined; | ||
| } | ||
|
|
||
| const STATE_TRANSITIONS: StateTransition[] = [ | ||
| { field: 'isChecking', message: 'Checking for update', level: 'info' }, | ||
| { | ||
| field: 'isUpdateAvailable', | ||
| message: 'Update available', | ||
| level: 'info', | ||
| getData: ctx => { | ||
| const updateId = ctx.latestManifest?.id; | ||
| return updateId ? { updateId } : undefined; | ||
| }, | ||
| }, | ||
| { field: 'isDownloading', message: 'Downloading update', level: 'info' }, | ||
| { | ||
| field: 'isUpdatePending', | ||
| message: 'Update downloaded', | ||
| level: 'info', | ||
| getData: ctx => { | ||
| const updateId = ctx.downloadedManifest?.id; | ||
| return updateId ? { updateId } : undefined; | ||
| }, | ||
| }, | ||
| { | ||
| field: 'checkError', | ||
| message: 'Update check failed', | ||
| level: 'error', | ||
| getData: ctx => ({ | ||
| error: (ctx.checkError as Error).message || String(ctx.checkError), | ||
| }), | ||
| }, | ||
| { | ||
| field: 'downloadError', | ||
| message: 'Update download failed', | ||
| level: 'error', | ||
| getData: ctx => ({ | ||
| error: (ctx.downloadError as Error).message || String(ctx.downloadError), | ||
| }), | ||
| }, | ||
| { | ||
| field: 'rollback', | ||
| message: 'Rollback directive received', | ||
| level: 'warning', | ||
| getData: ctx => ({ | ||
| commitTime: ctx.rollback!.commitTime, | ||
| }), | ||
| }, | ||
| { field: 'isRestarting', message: 'Restarting for update', level: 'info' }, | ||
| ]; | ||
|
|
||
| /** | ||
| * Listens to Expo Updates native state machine changes and records | ||
| * breadcrumbs for meaningful transitions such as checking for updates, | ||
| * downloading updates, errors, rollbacks, and restarts. | ||
| */ | ||
| export const expoUpdatesListenerIntegration = (): Integration => { | ||
| function setup(client: ReactNativeClient): void { | ||
| client.on('afterInit', () => { | ||
| if (!isExpo() || isExpoGo()) { | ||
| return; | ||
| } | ||
|
|
||
| const addListener = getAddUpdatesStateChangeListener(); | ||
| if (!addListener) { | ||
| debug.log('[ExpoUpdatesListener] expo-updates is not available, skipping.'); | ||
| return; | ||
| } | ||
|
|
||
| let previousContext: Partial<UpdatesNativeStateMachineContext> = {}; | ||
|
|
||
| addListener((event: UpdatesNativeStateChangeEvent) => { | ||
| const ctx = event.context; | ||
| handleStateChange(previousContext, ctx); | ||
| previousContext = ctx; | ||
| }); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Listener callback lacks try/catch, risking app crashMedium Severity The Triggered by project rule: PR Review Guidelines for Cursor Bot
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be valid 👍 |
||
| }); | ||
| } | ||
|
|
||
| return { | ||
| name: INTEGRATION_NAME, | ||
| setup, | ||
| }; | ||
| }; | ||
|
|
||
| /** | ||
| * Compares previous and current state machine contexts and emits | ||
| * breadcrumbs for meaningful transitions (falsy→truthy). | ||
| * | ||
| * @internal Exposed for testing purposes | ||
| */ | ||
| export function handleStateChange( | ||
| previous: Partial<UpdatesNativeStateMachineContext>, | ||
| current: UpdatesNativeStateMachineContext, | ||
| ): void { | ||
| for (const transition of STATE_TRANSITIONS) { | ||
| if (!previous[transition.field] && current[transition.field]) { | ||
| addBreadcrumb({ | ||
| category: BREADCRUMB_CATEGORY, | ||
| message: transition.message, | ||
| level: transition.level, | ||
| data: transition.getData?.(current), | ||
| }); | ||
| } | ||
| } | ||
| } | ||


There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should omit the blank line for consistency