chore(ttd): Fallback to activity holder if react context activity is not available #4779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eb1e19f | 433.55 ms | 444.90 ms | 11.35 ms |
| 6707be9 | 445.04 ms | 464.24 ms | 19.20 ms |
| a0b0298 | 427.50 ms | 428.10 ms | 0.60 ms |
| 5852d77 | 415.81 ms | 421.02 ms | 5.21 ms |
| e2aa97e | 481.09 ms | 475.31 ms | -5.78 ms |
| 623b5b8 | 460.59 ms | 491.39 ms | 30.80 ms |
| 62a750b | 395.96 ms | 423.36 ms | 27.41 ms |
| 7d161c0 | 413.02 ms | 435.29 ms | 22.26 ms |
| 7f6950b | 438.74 ms | 430.71 ms | -8.03 ms |
| 457e29f | 398.10 ms | 421.39 ms | 23.29 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| eb1e19f | 17.74 MiB | 20.08 MiB | 2.34 MiB |
| 6707be9 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
| a0b0298 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 5852d77 | 17.75 MiB | 20.11 MiB | 2.36 MiB |
| e2aa97e | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 623b5b8 | 17.75 MiB | 20.13 MiB | 2.38 MiB |
| 62a750b | 17.73 MiB | 19.93 MiB | 2.20 MiB |
| 7d161c0 | 17.75 MiB | 20.12 MiB | 2.37 MiB |
| 7f6950b | 17.74 MiB | 20.10 MiB | 2.36 MiB |
| 457e29f | 17.73 MiB | 19.84 MiB | 2.10 MiB |
Contributor
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8e80789+dirty | 1228.04 ms | 1237.20 ms | 9.16 ms |
| eb1e19f+dirty | 1209.56 ms | 1214.94 ms | 5.38 ms |
| 950b04f+dirty | 1223.18 ms | 1222.48 ms | -0.71 ms |
| 73fc872+dirty | 1236.16 ms | 1237.15 ms | 0.99 ms |
| e2aa97e+dirty | 1227.40 ms | 1233.65 ms | 6.26 ms |
| 48ad514+dirty | 1235.90 ms | 1238.20 ms | 2.31 ms |
| a989877+dirty | 1228.56 ms | 1227.71 ms | -0.85 ms |
| 5e5c392+dirty | 1231.96 ms | 1228.74 ms | -3.21 ms |
| 8c88ac7+dirty | 1205.13 ms | 1218.87 ms | 13.74 ms |
| 9c48b2c+dirty | 1246.96 ms | 1255.73 ms | 8.77 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8e80789+dirty | 2.36 MiB | 3.10 MiB | 759.43 KiB |
| eb1e19f+dirty | 2.36 MiB | 3.08 MiB | 737.21 KiB |
| 950b04f+dirty | 2.63 MiB | 3.78 MiB | 1.14 MiB |
| 73fc872+dirty | 2.63 MiB | 3.76 MiB | 1.13 MiB |
| e2aa97e+dirty | 2.63 MiB | 3.75 MiB | 1.12 MiB |
| 48ad514+dirty | 2.63 MiB | 3.75 MiB | 1.12 MiB |
| a989877+dirty | 2.36 MiB | 3.10 MiB | 752.40 KiB |
| 5e5c392+dirty | 2.63 MiB | 3.75 MiB | 1.12 MiB |
| 8c88ac7+dirty | 2.36 MiB | 3.10 MiB | 752.63 KiB |
| 9c48b2c+dirty | 2.36 MiB | 2.85 MiB | 495.77 KiB |
krystofwoldrich
requested review from
antonis and
lucas-zimerman
as code owners
antonis
approved these changes
Apr 29, 2025
Contributor
antonis
left a comment
antonis
left a comment
There was a problem hiding this comment.
The changes on this PR LGTM and are verified by the added unit tests independently of getsentry/sentry-java#4337 🚀
Contributor
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8ba5377+dirty | 361.68 ms | 370.62 ms | 8.94 ms |
| b3e6131+dirty | 365.70 ms | 362.98 ms | -2.72 ms |
| 22bcd92+dirty | 389.94 ms | 402.38 ms | 12.44 ms |
| 4297324+dirty | 385.33 ms | 435.68 ms | 50.35 ms |
| 63ed251+dirty | 485.02 ms | 531.16 ms | 46.14 ms |
| 1c65324+dirty | 381.10 ms | 427.26 ms | 46.16 ms |
| a989877+dirty | 383.04 ms | 400.92 ms | 17.88 ms |
| 153419c+dirty | 393.06 ms | 434.72 ms | 41.66 ms |
| 800171e+dirty | 432.15 ms | 549.63 ms | 117.48 ms |
| 2de79dc+dirty | 461.33 ms | 466.80 ms | 5.47 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8ba5377+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| b3e6131+dirty | 7.15 MiB | 8.40 MiB | 1.25 MiB |
| 22bcd92+dirty | 7.15 MiB | 8.39 MiB | 1.23 MiB |
| 4297324+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| 63ed251+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| 1c65324+dirty | 7.15 MiB | 8.22 MiB | 1.07 MiB |
| a989877+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| 153419c+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 800171e+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 2de79dc+dirty | 7.15 MiB | 8.40 MiB | 1.25 MiB |
Contributor
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8e80789+dirty | 1235.66 ms | 1223.78 ms | -11.88 ms |
| eb1e19f+dirty | 1229.91 ms | 1231.63 ms | 1.71 ms |
| 950b04f+dirty | 1220.28 ms | 1218.07 ms | -2.21 ms |
| 73fc872+dirty | 1235.27 ms | 1228.18 ms | -7.08 ms |
| e2aa97e+dirty | 1220.17 ms | 1219.81 ms | -0.36 ms |
| 48ad514+dirty | 1230.53 ms | 1233.76 ms | 3.22 ms |
| a989877+dirty | 1222.90 ms | 1219.89 ms | -3.00 ms |
| 5e5c392+dirty | 1224.72 ms | 1229.52 ms | 4.80 ms |
| 8c88ac7+dirty | 1240.66 ms | 1247.42 ms | 6.76 ms |
| 9c48b2c+dirty | 1253.39 ms | 1256.30 ms | 2.91 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 8e80789+dirty | 2.92 MiB | 3.67 MiB | 772.00 KiB |
| eb1e19f+dirty | 2.92 MiB | 3.64 MiB | 742.82 KiB |
| 950b04f+dirty | 3.19 MiB | 4.34 MiB | 1.16 MiB |
| 73fc872+dirty | 3.19 MiB | 4.33 MiB | 1.14 MiB |
| e2aa97e+dirty | 3.19 MiB | 4.32 MiB | 1.13 MiB |
| 48ad514+dirty | 3.19 MiB | 4.32 MiB | 1.13 MiB |
| a989877+dirty | 2.92 MiB | 3.66 MiB | 757.66 KiB |
| 5e5c392+dirty | 3.19 MiB | 4.32 MiB | 1.13 MiB |
| 8c88ac7+dirty | 2.92 MiB | 3.66 MiB | 757.12 KiB |
| 9c48b2c+dirty | 2.92 MiB | 3.41 MiB | 499.97 KiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR requires getsentry/sentry-java#4337 to be back ported to
sentry-java@v7.This PR adds a fallback to the Sentry Global Activity holder in case the react native context is missing current activity.
💚 How did you test it?
unit tests
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps