feat(toxgen): Generate TESTPATH for integrated test suites#4863
Merged
sentrivana merged 4 commits intomasterfrom Sep 25, 2025
Merged
feat(toxgen): Generate TESTPATH for integrated test suites#4863sentrivana merged 4 commits intomasterfrom
TESTPATH for integrated test suites#4863sentrivana merged 4 commits intomasterfrom
Conversation
TESTPATH for integrated test suites
❌ 64 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
alexander-alderman-webb
approved these changes
Sep 25, 2025
Comment on lines
+718
to
+724
| asgi: TESTPATH=tests/integrations/asgi | ||
| aws_lambda: TESTPATH=tests/integrations/aws_lambda | ||
| cloud_resource_context: TESTPATH=tests/integrations/cloud_resource_context | ||
| gcp: TESTPATH=tests/integrations/gcp | ||
| opentelemetry: TESTPATH=tests/integrations/opentelemetry | ||
| potel: TESTPATH=tests/integrations/opentelemetry | ||
| socket: TESTPATH=tests/integrations/socket |
Contributor
There was a problem hiding this comment.
Looks good!
I am wondering if we can auto-generate the TESTPATH for all integrations? The ones I have highlighted are still explicitly specified in tox.ninja.
Contributor
Author
There was a problem hiding this comment.
Those are hardcoded since those are tests suites that are not managed by toxgen. But agree that it looks a bit strange. Added at least a small comment e1a547c to clarify the different treatment for future reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Make toxgen generate the
TESTPATHenv var for integrated test suites, removing a manual step when adding a new test suite.Issues
Closes #4536
Reminders
tox -e linters.feat:,fix:,ref:,meta:)