Skip to content

feat(snuba): Add ConditionalFormula to Column proto for EAP queries #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
phacops wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(snuba): Add ConditionalFormula to Column proto for EAP queries #173

phacops wants to merge 2 commits into from

Conversation

@phacops
Copy link
Collaborator

@phacops phacops commented Jan 30, 2026

Add support for conditional expressions in EAP queries by introducing
ConditionalFormula and FormulaCondition message types to the Column proto.

This enables use cases like calculating hourly event rates with different
formulas based on aggregate values:

if(min(timestamp) < one_week_ago,
   count(*) / 168,                    -- use full week for old issues
   count(*) / hours_since_first_seen) -- use actual hours for new issues

Changes:

  • Add ConditionalFormula message with condition, match, and default fields
  • Add FormulaCondition message with comparison operators (left, op, right)
  • Add conditional_formula as field 7 in the Column oneof

@phacops @claude
feat(snuba): Add ConditionalFormula to Column proto for EAP queries
a83b6ba 
Add support for conditional expressions in EAP queries by introducing
ConditionalFormula and FormulaCondition message types to the Column
proto. This enables use cases like calculating hourly event rates with
different formulas based on aggregate values.

Co-Authored-By: Claude <noreply@anthropic.com>
@phacops phacops requested a review from a team as a code owner January 30, 2026 22:44
@github-actions
Copy link

github-actions bot commented Jan 30, 2026 •
edited
Loading

The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed⏩ skipped✅ passed✅ passedJan 30, 2026, 10:45 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phacops