feat(snuba): Add AnyAttributeFilter for searching across all attributes#172
Open
feat(snuba): Add AnyAttributeFilter for searching across all attributes#172
Conversation
Add a new AnyAttributeFilter message type to enable searching for a value across ALL attributes in EAP RPC endpoints, rather than requiring a specific attribute key. This is useful for broad searches where the user doesn't know which attribute contains the value they're looking for. The filter includes a restricted set of operations (EQUALS, NOT_EQUALS, LIKE, NOT_LIKE, IN, NOT_IN) that make sense for all-attribute search, excluding comparison ops like LESS_THAN that don't work across heterogeneous attribute types. Co-Authored-By: Claude <noreply@anthropic.com>
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new
AnyAttributeFiltermessage type to enable searching for a value across ALL attributes in EAP RPC endpoints, rather than requiring a specific attribute key.This is useful for broad searches where the user doesn't know which attribute contains the value they're looking for (e.g., searching for "error" across all string attributes).
Design decisions:
ComparisonFilter: Clearer semantics and allows restricting to sensible operations onlyattribute_typesfield: Allows callers to restrict which types to search (defaults to string-type attributes)Example usage:
// Find items where any attribute contains "error" TraceItemFilter { any_attribute_filter: AnyAttributeFilter { op: OP_LIKE value: AttributeValue { val_str: "%error%" } ignore_case: true } }