fix(native): Honor system crash reporter forwarding#1743
Open
jpnurmi wants to merge 2 commits into
Open
Conversation
Restore the signal handlers that were installed before Sentry before terminating after native crash processing. This lets runtimes and other crash handlers observe the crash after Sentry captures it. Co-Authored-By: OpenAI Codex <noreply@openai.com>
Propagate system_crash_reporter_enabled into the native crash context and use it on macOS after previous signal handlers have run. When disabled, exit without re-raising so the system crash reporter is not invoked by default. Co-Authored-By: OpenAI Codex <noreply@openai.com>
jpnurmi
force-pushed
the
jpnurmi/fix/native/system-crash-reporter
branch
from
4e69854 to
c28f9a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add signal chaining before final crash termination, then use that handoff to honor
system_crash_reporter_enabledon macOS.This keeps the native backend compatible with previously installed Unix signal handlers while allowing macOS crashes to skip the system crash reporter by default. When
system_crash_reporter_enabledis enabled, native forwards to the default signal path so the macOS system crash reporter can handle the crash.For reference, what Crashpad does:
As a bonus, this also lays the groundwork for runtimes such as Mono/CoreCLR that rely on signal-chaining: