Skip to content

feat: add transfer_timeout option for large uploads#1741

Open
jpnurmi wants to merge 3 commits into
masterfrom
jpnurmi/feat/transfer-timeout
Open

feat: add transfer_timeout option for large uploads#1741
jpnurmi wants to merge 3 commits into
masterfrom
jpnurmi/feat/transfer-timeout

Conversation

@jpnurmi
Copy link
Copy Markdown
Collaborator

@jpnurmi jpnurmi commented May 22, 2026

Add transfer_timeout as a dedicated option for SDK-managed HTTP transports. The proposed default is 0 (no transfer timeout), which was the previous default for curl.

This matters most for large uploads: without server-side chunked/resumable upload support, a long/hanging transfer can occupy the single-threaded transport pipeline for a long time.

Transfer timeouts were previously inconsistent across transports: curl had no total transfer timeout, while WinHTTP was capped by the 30s OS-default send/receive timeout that is too low for large uploads. This makes the behavior explicit and configurable without overloading shutdown_timeout, which only controls shutdown waits. Large uploads can also happen while retrying cached envelopes on restart, so the timeout needs to apply to HTTP transfer behavior rather than shutdown waiting.

Crashpad's own crash report upload does not support this option, but it does have a hardcoded 60s limit:

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2026

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 1b72b8a

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit dc70579. Configure here.

Comment thread src/transports/sentry_http_transport_winhttp.c
@jpnurmi jpnurmi requested review from bitsandfoxes and mujacica May 22, 2026 11:49
@jpnurmi jpnurmi force-pushed the jpnurmi/feat/transfer-timeout branch from 4c9c76c to 1b72b8a Compare May 22, 2026 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants