feat: add transfer_timeout option for large uploads#1741
Open
jpnurmi wants to merge 3 commits into
Open
Conversation
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit dc70579. Configure here.
4c9c76c to
1b72b8a
Compare
mujacica
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add
transfer_timeoutas a dedicated option for SDK-managed HTTP transports. The proposed default is 0 (no transfer timeout), which was the previous default for curl.This matters most for large uploads: without server-side chunked/resumable upload support, a long/hanging transfer can occupy the single-threaded transport pipeline for a long time.
Transfer timeouts were previously inconsistent across transports: curl had no total transfer timeout, while WinHTTP was capped by the 30s OS-default send/receive timeout that is too low for large uploads. This makes the behavior explicit and configurable without overloading
shutdown_timeout, which only controls shutdown waits. Large uploads can also happen while retrying cached envelopes on restart, so the timeout needs to apply to HTTP transfer behavior rather than shutdown waiting.Crashpad's own crash report upload does not support this option, but it does have a hardcoded 60s limit: