-
-
Notifications
You must be signed in to change notification settings - Fork 200
feat: add sentry__value_from_msgpack
#1492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jpnurmi
wants to merge
6
commits into
master
Choose a base branch
from
jpnurmi/feat/sentry-value-from-msgpack
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+433
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
When parsing multiple sequential msgpack values where the first value is a list, subsequent values were incorrectly appended directly to that list instead of creating a wrapper list (e.g., [1,2] followed by 3 produced [1,2,3] instead of [[1,2], 3]). Fix by checking on the first iteration if there's more data coming. If so, immediately wrap the first value in a list, ensuring the wrapper list is created upfront when needed. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
When mpack_write_i64() serializes positive int64 values, it optimizes them using unsigned formats. The deserialization was treating all values above INT32_MAX as uint64, which broke round-trip for signed integers. Now values in range (INT32_MAX, INT64_MAX] deserialize as int64, and only values > INT64_MAX deserialize as uint64. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
mpack_node_double() handles both types, so no need for separate cases. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jpnurmi
added a commit
that referenced
this pull request
Jan 26, 2026
Add explicit cases for mpack_type_missing and mpack_type_bin to satisfy -Wswitch-enum compiler flag. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
jpnurmi
added a commit
that referenced
this pull request
Jan 26, 2026
jpnurmi
added a commit
that referenced
this pull request
Jan 26, 2026
jpnurmi
added a commit
that referenced
this pull request
Jan 26, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The opposite of
sentry_value_to_msgpack. For offline caching of Crashpad envelopes.Required for:
Example usage for msgpacked crashpad attachments (
__sentry-eventand__sentry-breadcrumbsN):sentry-native/src/backends/sentry_backend_crashpad.cpp
Lines 436 to 447 in ff864c4
#skip-changelog (internal)