-
-
Notifications
You must be signed in to change notification settings - Fork 200
ci(release): Switch from action-prepare-release to Craft #1477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BYK
wants to merge
15
commits into
master
Choose a base branch
from
ci/migrate-to-craft-action
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f02eeec
ci(release): Switch from action-prepare-release to Craft
BYK 45e5b1d
ci(release): Restore GitHub App token authentication
BYK 51c0cab
fix: Pin actions to SHA and add permissions blocks
BYK 9818aad
fix: Use correct action version SHAs (restore original versions)
BYK de0e0e5
fix: Use correct action version SHAs (restore original versions)
BYK 7c7dd01
fix: Clean up action version comments
BYK 48ff999
Update Craft SHA to 1c58bfd57bfd6a967b6f3fc92bead2c42ee698ce
BYK 281c2c3
Add explicit permissions block to ci.yml
BYK 8150d28
Add explicit permissions block to enforce-license-compliance.yml
BYK 5dae44f
Revert permissions changes to ci.yml
BYK 227f81c
Revert permissions changes to enforce-license-compliance.yml
BYK 085dd44
fix: revert extraneous changes to non-release workflow files
BYK 8ab4e37
fix: clean up release.yml formatting and version comments
BYK e4ac648
build(craft): Update Craft action to c6e2f04
BYK 33b6491
chore: add unlabeled trigger to changelog-preview
BYK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| name: Changelog Preview | ||
| on: | ||
| pull_request: | ||
| types: | ||
| - opened | ||
| - synchronize | ||
| - reopened | ||
| - edited | ||
| - labeled | ||
| - unlabeled | ||
| permissions: | ||
| contents: write | ||
| pull-requests: write | ||
|
|
||
| jobs: | ||
| changelog-preview: | ||
| uses: getsentry/craft/.github/workflows/changelog-preview.yml@v2 | ||
| secrets: inherit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows ARM64 build missing architecture specification
Medium Severity
The new Windows arm64 matrix entry specifies
os: windows-11-armbut doesn't include any flag to indicate ARM64 architecture. The build scripts intests/cmake.pyandscripts/install-zlib.ps1have explicit handling for 32-bit builds viaTEST_X86(passing-AWin32to CMake), but no equivalent handling exists for ARM64. Without an architecture flag like-AARM64, CMake defaults to x64 even on ARM64 Windows, resulting in x64 binaries instead of native ARM64 binaries.