Skip to content

fix(logs): add debug output for structured logs when debug option is enabled #1466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JoshuaMoelans wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix(logs): add debug output for structured logs when debug option is enabled #1466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7a180e4
add printf for logs when debug is true
JoshuaMoelans Dec 15, 2025
85239d6
use existing SENTRY_(LEVEL) macros
JoshuaMoelans Dec 15, 2025
052c03b
update CHANGELOG.md
JoshuaMoelans Dec 15, 2025
2042605
add future TODO + fix null-log
JoshuaMoelans Dec 15, 2025
5c6543f
make debug_print_log static
JoshuaMoelans Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- Removed the 10-item limit per envelope for non-session data. Sessions are now limited to 100 per envelope, while other items (e.g., attachments) have no limit in amount. ([#1347](https://github.com/getsentry/sentry-native/pull/1347))
- Align the `breakpad` interface changes introduced with [#1083](https://github.com/getsentry/sentry-native/pull/1083) with the corresponding iOS build. ([#1465](https://github.com/getsentry/sentry-native/pull/1465))
- Add structured logs to debug output when `debug` option is set. ([#1466](https://github.com/getsentry/sentry-native/pull/1466))

## 0.12.2

Expand Down
5 changes: 5 additions & 0 deletions src/sentry_logger.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,4 +46,9 @@ void sentry__logger_disable(void);

#define SENTRY_ERROR(message) sentry__logger_log(SENTRY_LEVEL_ERROR, message)

#define SENTRY_FATALF(message, ...) \
sentry__logger_log(SENTRY_LEVEL_FATAL, message, __VA_ARGS__)

#define SENTRY_FATAL(message) sentry__logger_log(SENTRY_LEVEL_FATAL, message)

#endif
32 changes: 32 additions & 0 deletions src/sentry_logs.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -752,6 +752,33 @@ construct_log(sentry_level_t level, const char *message, va_list args)
return log;
}

static void
debug_print_log(sentry_level_t level, const char *log_body)
{
// TODO if we enable our debug-macro as logging integration
// we need to avoid recursion here
switch (level) {
case SENTRY_LEVEL_TRACE:
SENTRY_TRACEF("LOG: %s", log_body);
break;
case SENTRY_LEVEL_DEBUG:
SENTRY_DEBUGF("LOG: %s", log_body);
break;
case SENTRY_LEVEL_INFO:
SENTRY_INFOF("LOG: %s", log_body);
break;
case SENTRY_LEVEL_WARNING:
SENTRY_WARNF("LOG: %s", log_body);
break;
case SENTRY_LEVEL_ERROR:
SENTRY_ERRORF("LOG: %s", log_body);
break;
case SENTRY_LEVEL_FATAL:
SENTRY_FATALF("LOG: %s", log_body);
break;
}
}

log_return_value_t
sentry__logs_log(sentry_level_t level, const char *message, va_list args)
{
Expand All @@ -774,6 +801,11 @@ sentry__logs_log(sentry_level_t level, const char *message, va_list args)
discarded = true;
}
}
if (options->debug && !sentry_value_is_null(log)) {
debug_print_log(level,
sentry_value_as_string(
sentry_value_get_by_key(log, "body")));
}
}
if (discarded) {
return SENTRY_LOG_RETURN_DISCARD;
Expand Down
Loading