feat(effect): Add extra opt-in for logs and metrics#19755
Merged
JPeer264 merged 2 commits intojp/add-effect-sdkfrom Mar 11, 2026
Merged
feat(effect): Add extra opt-in for logs and metrics#19755JPeer264 merged 2 commits intojp/add-effect-sdkfrom
JPeer264 merged 2 commits intojp/add-effect-sdkfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
andreiborza
reviewed
Mar 11, 2026
| * dsn: '__DSN__', | ||
| * enableLogs: true, | ||
| * enableMetrics: true, | ||
| * enableEffectLogs: true, |
Member
There was a problem hiding this comment.
m: We should probably keep enableLogs in the example too, otherwise you wouldn't get logs just with this right?
Member
Author
There was a problem hiding this comment.
That is true, let's keep that in.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| attributes: { ...attributes, word }, | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
Frequency metrics overcounted on every periodic flush
High Severity
Frequency metrics use sentryMetrics.count with cumulative occurrence values from metricState.occurrences, but unlike counter metrics, they bypass the delta calculation in sendDeltaMetricToSentry. Since flushMetricsToSentry runs every 10 seconds via the layer's scheduler, each flush re-sends the full cumulative count. After N flushes, Sentry shows roughly N × actual_count for each word. Frequency metrics need the same delta treatment that counters receive.
Additional Locations (1)
JPeer264
force-pushed
the
jp/add-effect-sdk-stack/5.5
branch
from
87daa55 to
5beef22
Compare
JPeer264
force-pushed
the
jp/add-effect-sdk-stack/5.5
branch
from
5beef22 to
930bbf5
Compare
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is now adding a different naming schema for enabling logs and metrics based on: https://develop.sentry.dev/sdk/telemetry/metrics/#auto-emitted-metrics
For the logs I also added them, which might not make the most sense, as
enableLogsis nowfalseby default, which means that there is a double opt-in needed to make logs work viaEffect.log.The naming is TBD, but this is the best I came up with:
enableEffectLogs&enableEffectMetrics