Conversation
Contributor
size-limit report 📦
|
Lms24
force-pushed
the
lms/chore-astro-6
branch
from
6aa1cfe to
5ef38d1
Compare
Lms24
force-pushed
the
lms/chore-astro-6
branch
from
46c4887 to
2ef1f2a
Compare
JPeer264
approved these changes
Mar 11, 2026
Member
JPeer264
left a comment
JPeer264
left a comment
There was a problem hiding this comment.
Amazing work thank you. Got 2 comments and there is 1 failing lint CI job
Lms24
changed the title
Co-authored-by: Jan Peer Stöcklmair <jan.peer@sentry.io>
Lms24
commented
Mar 11, 2026
Lms24
commented
Mar 11, 2026
| // This handles the case where a previous handler disposed the client | ||
| // but the scope still holds a reference to it (e.g., alarm handlers in Durable Objects) | ||
| if (!currentClient || !currentClient.getTransport()) { | ||
| if (!currentClient?.getTransport()) { |
Member
Author
There was a problem hiding this comment.
1 failing lint CI job
This failed linting, unrelated to the actual PR. Gonna just add this to the PR to quickly fix this on develop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adjusts our Astro middleware to be compatible with Astro 6. It also adds an e2e test app for Astro 6 on the node adapter.
Changes:
package.jsonctx.[Symbol.for('astro.pipeline')]instead ofctx.[Symbol.for('context.routes')]ref #19753