Skip to content

fix(consola): Normalize extra keys from consola#19511

Open
s1gr1d wants to merge 6 commits intodevelopfrom
sig/consola-extra-keys
Open

fix(consola): Normalize extra keys from consola#19511
s1gr1d wants to merge 6 commits intodevelopfrom
sig/consola-extra-keys

Conversation

@s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Feb 25, 2026

The JS doc states that extra keys are added as consola. log attributes. However, this is not the case.

Extra keys can be added by, for example, calling the Consola reporter directly or by calling consola.[type]({ message: '', ... }).

Part of this PR (split up for better reviewing): #18602

Closes #19512 (added automatically)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

size-limit report 📦

Path Size % Change Change
@sentry/browser 25.62 kB - -
@sentry/browser - with treeshaking flags 24.12 kB - -
@sentry/browser (incl. Tracing) 42.42 kB - -
@sentry/browser (incl. Tracing, Profiling) 47.09 kB - -
@sentry/browser (incl. Tracing, Replay) 81.24 kB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 70.86 kB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 85.94 kB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 98.2 kB - -
@sentry/browser (incl. Feedback) 42.43 kB - -
@sentry/browser (incl. sendFeedback) 30.29 kB - -
@sentry/browser (incl. FeedbackAsync) 35.34 kB - -
@sentry/browser (incl. Metrics) 26.79 kB - -
@sentry/browser (incl. Logs) 26.93 kB - -
@sentry/browser (incl. Metrics & Logs) 27.61 kB - -
@sentry/react 27.37 kB - -
@sentry/react (incl. Tracing) 44.76 kB - -
@sentry/vue 30.07 kB - -
@sentry/vue (incl. Tracing) 44.27 kB - -
@sentry/svelte 25.64 kB - -
CDN Bundle 28.16 kB - -
CDN Bundle (incl. Tracing) 43.25 kB - -
CDN Bundle (incl. Logs, Metrics) 29 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) 44.09 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) 68.08 kB - -
CDN Bundle (incl. Tracing, Replay) 80.13 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 80.99 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 85.64 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 86.53 kB - -
CDN Bundle - uncompressed 82.34 kB - -
CDN Bundle (incl. Tracing) - uncompressed 128.06 kB - -
CDN Bundle (incl. Logs, Metrics) - uncompressed 85.18 kB - -
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 130.89 kB - -
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 208.84 kB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 244.94 kB - -
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 247.76 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 257.85 kB - -
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 260.66 kB - -
@sentry/nextjs (client) 47.17 kB - -
@sentry/sveltekit (client) 42.88 kB - -
@sentry/node-core 52.18 kB +0.02% +9 B 🔺
@sentry/node 173.46 kB +0.01% +9 B 🔺
@sentry/node - without tracing 97.33 kB +0.01% +8 B 🔺
@sentry/aws-serverless 113.13 kB +0.01% +7 B 🔺

View base workflow run

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,490 - 8,686 -2%
GET With Sentry 1,637 19% 1,665 -2%
GET With Sentry (error only) 5,933 70% 5,985 -1%
POST Baseline 1,156 - 1,188 -3%
POST With Sentry 576 50% 594 -3%
POST With Sentry (error only) 1,028 89% 1,042 -1%
MYSQL Baseline 3,233 - 3,211 +1%
MYSQL With Sentry 449 14% 474 -5%
MYSQL With Sentry (error only) 2,623 81% 2,641 -1%

View base workflow run

@s1gr1d s1gr1d requested a review from chargome February 25, 2026 09:17
@s1gr1d s1gr1d force-pushed the sig/consola-extra-keys branch from b4b3486 to bc63ae2 Compare February 25, 2026 09:20
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@s1gr1d s1gr1d force-pushed the sig/consola-extra-keys branch from a6fd7e6 to 676b162 Compare February 25, 2026 12:05
@s1gr1d s1gr1d enabled auto-merge (squash) February 25, 2026 12:16
@s1gr1d s1gr1d changed the title fix(consola): Add extra keys as consola. prefixed attributes fix(consola): Add extra keys from consola as attributes Feb 25, 2026
@s1gr1d s1gr1d changed the title fix(consola): Add extra keys from consola as attributes fix(consola): Normalize extra keys from consola Feb 25, 2026
@s1gr1d s1gr1d disabled auto-merge February 25, 2026 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(consola): Add extra keys as consola. prefixed attributes

2 participants