[Gitflow] Merge master into develop#19498
[Gitflow] Merge master into develop#19498javascript-sdk-gitflow[bot] wants to merge 2 commits intodevelopfrom
Conversation
meta(changelog): Update changelog for 10.40.0
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Bit too ealry... |
Pull request was closed
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 4 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| - feat(node): Bump to latest @fastify/otel ([#19452](https://github.com/getsentry/sentry-javascript/pull/19452)) | ||
| - fix: Bump bundler plugins to v5 ([#19468](https://github.com/getsentry/sentry-javascript/pull/19468)) | ||
| - fix: updated the codecov config ([#19350](https://github.com/getsentry/sentry-javascript/pull/19350)) | ||
| - fix(aws-serverless): Prevent crash in` isPromiseAllSettledResult` with null/undefined array elements ([#19346](https://github.com/getsentry/sentry-javascript/pull/19346)) |
There was a problem hiding this comment.
Missing space before backtick in changelog entry
Low Severity
The changelog entry has a formatting error where in isPromiseAllSettledResult is missing a space between `in` and the opening backtick. It should read `in `isPromiseAllSettledResult to properly format the function name in backticks.
| - fix: Bump bundler plugins to v5 ([#19468](https://github.com/getsentry/sentry-javascript/pull/19468)) | ||
| - fix: updated the codecov config ([#19350](https://github.com/getsentry/sentry-javascript/pull/19350)) | ||
| - fix(aws-serverless): Prevent crash in` isPromiseAllSettledResult` with null/undefined array elements ([#19346](https://github.com/getsentry/sentry-javascript/pull/19346)) | ||
| - fix(bun) Export pinoIntegration from @sentry/node ([#17990](https://github.com/getsentry/sentry-javascript/pull/17990)) |
There was a problem hiding this comment.
Missing colon in changelog entry format
Low Severity
The changelog entry fix(bun) Export pinoIntegration is missing the conventional colon after the scope parenthesis. It should be fix(bun): Export pinoIntegration to match the project's changelog format convention used throughout the file.
| - feat(node): Add `ignoreConnectSpans` option to `postgresIntegration` ([#19291](https://github.com/getsentry/sentry-javascript/pull/19291)) | ||
| - feat(node): Bump to latest @fastify/otel ([#19452](https://github.com/getsentry/sentry-javascript/pull/19452)) | ||
| - fix: Bump bundler plugins to v5 ([#19468](https://github.com/getsentry/sentry-javascript/pull/19468)) | ||
| - fix: updated the codecov config ([#19350](https://github.com/getsentry/sentry-javascript/pull/19350)) |
There was a problem hiding this comment.
Incorrect capitalization in changelog entry
Low Severity
The changelog entry fix: updated the codecov config starts with lowercase "updated" instead of uppercase "Updated". This violates the changelog convention where descriptions start with capital letters after the type prefix.
| <summary><strong>Internal Changes</strong></summary> | ||
| - test(nextjs): Add bun e2e test app ([#19318](https://github.com/getsentry/sentry-javascript/pull/19318)) | ||
| - test(nextjs): Deactivate canary test for cf-workers ([#19483](https://github.com/getsentry/sentry-javascript/pull/19483)) | ||
| - tests(langchain): Fix langchain v1 internal error tests ([#19409](https://github.com/getsentry/sentry-javascript/pull/19409)) |
There was a problem hiding this comment.
Incorrect type prefix in changelog entry
Low Severity
The changelog entry uses tests(langchain): with a plural "tests" prefix instead of the singular "test" prefix used consistently throughout the changelog for test-related entries.
2 participants
Merge master branch into develop