ref(react): Remove lazy route machinery in favour of lazyRouteManifest#19466
Open
onurtemizkan wants to merge 3 commits intodevelopfrom
Open
ref(react): Remove lazy route machinery in favour of lazyRouteManifest#19466onurtemizkan wants to merge 3 commits intodevelopfrom
lazyRouteManifest#19466onurtemizkan wants to merge 3 commits intodevelopfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
packages/react/src/reactrouter-compat-utils/instrumentation.tsx
Outdated
Show resolved
Hide resolved
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
onurtemizkan
force-pushed
the
onur/clean-up-lazy-route-logic
branch
from
e7ab1da to
38bf328
Compare
Comment on lines
+937
to
947
| if (source === 'route') { | ||
| startBrowserTracingNavigationSpan(client, { | ||
| name, | ||
| attributes: { | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: source, | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_OP]: 'navigation', | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: `auto.navigation.react.reactrouter_v${version}`, | ||
| }, | ||
| }); | ||
| } | ||
| } |
There was a problem hiding this comment.
Bug: The manifest fallback path in handleNavigation creates new navigation spans without checking for duplicates, unlike the primary path, leading to multiple spans for a single navigation.
Severity: MEDIUM
Suggested Fix
The manifest fallback path in handleNavigation should replicate the duplicate detection logic from the primary path. Before creating a new span, check activeNavigationSpans for an existing navigation. If one exists, update it. If not, create a new span and add it to the activeNavigationSpans map to ensure it is tracked.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/react/src/reactrouter-compat-utils/instrumentation.tsx#L920-L947
Potential issue: When `handleNavigation` is called multiple times while `branches` is
null (e.g., during a transition before lazy routes are loaded), the manifest fallback
logic is triggered. This path creates a new navigation span via
`startBrowserTracingNavigationSpan` on each invocation. Unlike the primary path, it does
not check the `activeNavigationSpans` map for existing navigations or add the new span
to it. This results in multiple untracked spans for the same logical navigation,
bypassing deduplication and potentially causing a memory leak.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #19086
This removes the lazy route machinery (
patchSpanEnd,trackLazyRouteLoad,createDeferredLazyRoutePromise,pendingLazyRouteLoads,deferredLazyRouteResolvers,shouldUpdateWildcardSpanName,tryUpdateSpanNameBeforeEnd, etc.) that was previously used to handle parameterized route naming for lazy routes.The series of fixes for this over time (#17867, #17962, #18098, #18155, #18346, #18881, #18898) added increasingly complex race condition handling, deferred promise mechanisms, and span end patching, all trying to ensure correct transaction names when lazy routes hadn't loaded yet. With
lazyRouteManifestintroduced in #19086, we no longer need any of this. The manifest provides the parameterized route name upfront, without needing to wait for route resolution.Removed:
patchSpanEndand the entirespan.end()monkey-patching mechanismtrackLazyRouteLoad/pendingLazyRouteLoadspromise trackingcreateDeferredLazyRoutePromise/resolveDeferredLazyRoutePromisedeferred resolutionshouldUpdateWildcardSpanName/tryUpdateSpanNameBeforeEndwildcard upgrade logic__sentry_may_have_lazy_routes__span flaghandleNavigationandupdatePageloadTransactionAgnosticDataRouteMatchtype import (only used for the removed matches parameter)lazyRouteTimeoutis deprecated with a runtime warning, pointing users tolazyRouteManifest.The
updatePageloadTransactionretains a manifest fallback for the case wherematchRoutesreturns no branches during initial pageload (lazy routes not yet loaded).handleNavigationdoesn't need this as React Router only updatesstate.locationwhen navigation completes (idle), so routes are already resolved.