Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dev-packages/node-overhead-gh-action/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@actions/core": "1.10.1",
"@actions/exec": "1.1.1",
"@actions/github": "^5.0.0",
"@actions/glob": "0.4.0",
"@actions/glob": "0.6.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Upgrading @actions/glob introduces a dependency on @actions/core@^3.0.0, which conflicts with the explicitly pinned direct dependency on @actions/core@1.10.1 in package.json.
Severity: HIGH

Suggested Fix

To resolve the conflict, update the @actions/core dependency in both package.json files to a version compatible with what @actions/glob@0.6.1 expects, for example: "@actions/core": "^3.0.0".

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: dev-packages/node-overhead-gh-action/package.json#L35

Potential issue: The pull request upgrades the `@actions/glob` dependency to version
`0.6.1`. This new version of `@actions/glob` has a transitive dependency on
`@actions/core@^3.0.0`. However, the `package.json` files for `node-overhead-gh-action`
and `size-limit-gh-action` still explicitly pin the direct dependency to
`@actions/core@1.10.1`. This creates a version conflict between the direct dependency
(`1.10.1`) and the transitive dependency (`^3.0.0`). This incomplete dependency
migration is likely to cause runtime failures if the package manager resolves to version
`3.0.0`, as the code was written for the `1.x` API and major version bumps often include
breaking changes.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would you flag this? We use @actions/core for our actions in the repo. This has nothing to do with @actions/glob

"@actions/io": "1.1.3",
"autocannon": "^8.0.0",
"eslint-plugin-regexp": "^1.15.0",
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/size-limit-gh-action/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"@actions/core": "1.10.1",
"@actions/exec": "1.1.1",
"@actions/github": "^5.0.0",
"@actions/glob": "0.4.0",
"@actions/glob": "0.6.1",
"@actions/io": "1.1.3",
"bytes-iec": "3.1.1",
"markdown-table": "3.0.3"
Expand Down
48 changes: 34 additions & 14 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,6 @@
"@actions/http-client" "^2.0.1"
uuid "^8.3.2"

"@actions/core@^1.9.1":
version "1.11.1"
resolved "https://registry.yarnpkg.com/@actions/core/-/core-1.11.1.tgz#ae683aac5112438021588030efb53b1adb86f172"
integrity sha512-hXJCSrkwfA46Vd9Z3q4cpEpHB1rL5NG04+/rbqW9d3+CSvtB1tYe8UTpAlixa1vj0m/ULglfEK2UKxMGxCxv5A==
dependencies:
"@actions/exec" "^1.1.1"
"@actions/http-client" "^2.0.1"

"@actions/core@^2.0.0":
version "2.0.3"
resolved "https://registry.yarnpkg.com/@actions/core/-/core-2.0.3.tgz#b05e8cf407ab393e5d10282357a74e1ee2315eee"
Expand All @@ -45,7 +37,15 @@
"@actions/exec" "^2.0.0"
"@actions/http-client" "^3.0.2"

"@actions/exec@1.1.1", "@actions/exec@^1.1.1":
"@actions/core@^3.0.0":
version "3.0.0"
resolved "https://registry.yarnpkg.com/@actions/core/-/core-3.0.0.tgz#89cb07c119e9b46a649ad5f355e77de9b3108cf8"
integrity sha512-zYt6cz+ivnTmiT/ksRVriMBOiuoUpDCJJlZ5KPl2/FRdvwU3f7MPh9qftvbkXJThragzUZieit2nyHUyw53Seg==
dependencies:
"@actions/exec" "^3.0.0"
"@actions/http-client" "^4.0.0"

"@actions/exec@1.1.1":
version "1.1.1"
resolved "https://registry.yarnpkg.com/@actions/exec/-/exec-1.1.1.tgz#2e43f28c54022537172819a7cf886c844221a611"
integrity sha512-+sCcHHbVdk93a0XT19ECtO/gIXoxvdsgQLzb2fE2/5sIZmWQuluYyjPQtrtTHdU1YzTZ7bAPN4sITq2xi1679w==
Expand All @@ -59,6 +59,13 @@
dependencies:
"@actions/io" "^2.0.0"

"@actions/exec@^3.0.0":
version "3.0.0"
resolved "https://registry.yarnpkg.com/@actions/exec/-/exec-3.0.0.tgz#8c3464d20f0aa4068707757021d7e3c01a7ee203"
integrity sha512-6xH/puSoNBXb72VPlZVm7vQ+svQpFyA96qdDBvhB8eNZOE8LtPf9L4oAsfzK/crCL8YZ+19fKYVnM63Sl+Xzlw==
dependencies:
"@actions/io" "^3.0.2"

"@actions/github@^5.0.0":
version "5.1.1"
resolved "https://registry.yarnpkg.com/@actions/github/-/github-5.1.1.tgz#40b9b9e1323a5efcf4ff7dadd33d8ea51651bbcb"
Expand All @@ -82,12 +89,12 @@
"@octokit/request-error" "^5.1.1"
undici "^5.28.5"

"@actions/glob@0.4.0":
version "0.4.0"
resolved "https://registry.yarnpkg.com/@actions/glob/-/glob-0.4.0.tgz#b169b1c1c72f41e5df7b3d9349539c88fa68403c"
integrity sha512-+eKIGFhsFa4EBwaf/GMyzCdWrXWymGXfFmZU3FHQvYS8mPcHtTtZONbkcqqUMzw9mJ/pImEBFET1JNifhqGsAQ==
"@actions/glob@0.6.1":
version "0.6.1"
resolved "https://registry.yarnpkg.com/@actions/glob/-/glob-0.6.1.tgz#4820bfd86175dd98cd63d3d557e47bb09a21c7d0"
integrity sha512-K4+2Ac5ILcf2ySdJCha+Pop9NcKjxqCL4xL4zI50dgB2PbXgC0+AcP011xfH4Of6b4QEJJg8dyZYv7zl4byTsw==
dependencies:
"@actions/core" "^1.9.1"
"@actions/core" "^3.0.0"
minimatch "^3.0.4"

"@actions/http-client@^2.0.1", "@actions/http-client@^2.2.0":
Expand All @@ -106,6 +113,14 @@
tunnel "^0.0.6"
undici "^6.23.0"

"@actions/http-client@^4.0.0":
version "4.0.0"
resolved "https://registry.yarnpkg.com/@actions/http-client/-/http-client-4.0.0.tgz#f9754133c22802466482bf96321d42f2dba1fc82"
integrity sha512-QuwPsgVMsD6qaPD57GLZi9sqzAZCtiJT8kVBCDpLtxhL5MydQ4gS+DrejtZZPdIYyB1e95uCK9Luyds7ybHI3g==
dependencies:
tunnel "^0.0.6"
undici "^6.23.0"

"@actions/io@1.1.3", "@actions/io@^1.0.1":
version "1.1.3"
resolved "https://registry.yarnpkg.com/@actions/io/-/io-1.1.3.tgz#4cdb6254da7962b07473ff5c335f3da485d94d71"
Expand All @@ -116,6 +131,11 @@
resolved "https://registry.yarnpkg.com/@actions/io/-/io-2.0.0.tgz#3ad1271ba3cd515324f2215e8d4c1c0c3864d65b"
integrity sha512-Jv33IN09XLO+0HS79aaODsvIRyduiF7NY/F6LYeK5oeUmrsz7aFdRphQjFoESF4jS7lMauDOttKALcpapVDIAg==

"@actions/io@^3.0.2":
version "3.0.2"
resolved "https://registry.yarnpkg.com/@actions/io/-/io-3.0.2.tgz#6f89b27a159d109836d983efa283997c23b92284"
integrity sha512-nRBchcMM+QK1pdjO7/idu86rbJI5YHUKCvKs0KxnSYbVe3F51UfGxuZX4Qy/fWlp6l7gWFwIkrOzN+oUK03kfw==

"@adobe/css-tools@^4.0.1", "@adobe/css-tools@^4.4.0":
version "4.4.3"
resolved "https://registry.yarnpkg.com/@adobe/css-tools/-/css-tools-4.4.3.tgz#beebbefb0264fdeb32d3052acae0e0d94315a9a2"
Expand Down
Loading