Skip to content

feat(deps): bump minimatch from 9.0.5 to 10.2.1 #19399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dependabot wants to merge 1 commit into from
+19 −7
Closed

feat(deps): bump minimatch from 9.0.5 to 10.2.1 #19399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
"@sentry/node-core": "10.39.0",
"@sentry/opentelemetry": "10.39.0",
"import-in-the-middle": "^2.0.6",
"minimatch": "^9.0.0"
"minimatch": "^10.2.1"
Copy link

@sentry sentry bot Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The minimatch dependency upgrade requires Node.js 20+, but the package still declares support for Node.js 18, causing a breaking incompatibility and runtime failures.
Severity: HIGH

Suggested Fix

Either update the engines field in packages/node/package.json to require Node.js 20+ to reflect the new minimum requirement, or revert the minimatch dependency to a version compatible with Node.js 18 (e.g., version 9.x).

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: packages/node/package.json#L102

Potential issue: The `@sentry/node` package declares support for Node.js 18 and above
via its `engines` field. This change introduces a dependency on `minimatch` version
10.2.1, which requires Node.js 20 or higher. This creates a version incompatibility that
will cause runtime failures for users running the package on Node.js 18 or 19. This is a
breaking change that is not reflected in the package's declared engine requirements and
will likely cause CI jobs running on Node.js 18 to fail.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link

@cursor cursor bot Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Major dependency bump narrows Node.js version support

High Severity

Bumping minimatch from ^9.0.0 to ^10.2.1 introduces a Node.js version compatibility gap. minimatch v10 declares "engines": { "node": "20 || >=22" }, but @sentry/node officially supports Node 18.0.0+, as confirmed by Sentry docs and the "@types/node": "^18.19.1" devDependency. Users on Node 18 would receive a dependency that doesn't support their runtime, potentially causing failures. This is a breaking change for the package's supported platform matrix.

Fix in Cursor Fix in Web

Triggered by project rule: PR Review Guidelines for Cursor Bot

},
"devDependencies": {
"@types/node": "^18.19.1"
Expand Down
24 changes: 18 additions & 6 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5407,7 +5407,7 @@
resolved "https://registry.yarnpkg.com/@isaacs/balanced-match/-/balanced-match-4.0.1.tgz#3081dadbc3460661b751e7591d7faea5df39dd29"
integrity sha512-yzMTt9lEb8Gv7zRioUilSglI0c0smZ9k5D65677DLWLtWJaXIS3CqcGyUFByYKlnUj6TkjLVs54fBl6+TiGQDQ==

"@isaacs/brace-expansion@^5.0.0", "@isaacs/brace-expansion@^5.0.1":
"@isaacs/brace-expansion@^5.0.0":
version "5.0.1"
resolved "https://registry.yarnpkg.com/@isaacs/brace-expansion/-/brace-expansion-5.0.1.tgz#0ef5a92d91f2fff2a37646ce54da9e5f599f6eff"
integrity sha512-WMz71T1JS624nWj2n2fnYAuPovhv7EUhk69R6i9dsVyzxt5eM3bjwvgk9L+APE1TRscGysAVMANkB0jh0LQZrQ==
Expand Down Expand Up @@ -12447,6 +12447,11 @@ balanced-match@^1.0.0:
resolved "https://registry.yarnpkg.com/balanced-match/-/balanced-match-1.0.2.tgz#e83e3a7e3f300b34cb9d87f615fa0cbf357690ee"
integrity sha512-3oSeUO0TMV67hN1AmbXsK4yaqU7tjiHlbxRDZOpH0KW9+CeX4bRAaX0Anxt0tx2MrpRpWwQaPwIlISEJhYU5Pw==

balanced-match@^4.0.2:
version "4.0.3"
resolved "https://registry.yarnpkg.com/balanced-match/-/balanced-match-4.0.3.tgz#6337a2f23e0604a30481423432f99eac603599f9"
integrity sha512-1pHv8LX9CpKut1Zp4EXey7Z8OfH11ONNH6Dhi2WDUt31VVZFXZzKwXcysBgqSumFCmR+0dqjMK5v5JiFHzi0+g==

bare-events@^2.2.0, bare-events@^2.5.4:
version "2.5.4"
resolved "https://registry.yarnpkg.com/bare-events/-/bare-events-2.5.4.tgz#16143d435e1ed9eafd1ab85f12b89b3357a41745"
Expand Down Expand Up @@ -12774,6 +12779,13 @@ brace-expansion@^2.0.1:
dependencies:
balanced-match "^1.0.0"

brace-expansion@^5.0.2:
version "5.0.2"
resolved "https://registry.yarnpkg.com/brace-expansion/-/brace-expansion-5.0.2.tgz#b6c16d0791087af6c2bc463f52a8142046c06b6f"
integrity sha512-Pdk8c9poy+YhOgVWw1JNN22/HcivgKWwpxKq04M/jTmHyCZn12WPJebZxdjSa5TmBqISrUSgNYU3eRORljfCCw==
dependencies:
balanced-match "^4.0.2"

braces@^2.3.1:
version "2.3.2"
resolved "https://registry.yarnpkg.com/braces/-/braces-2.3.2.tgz#5979fd3f14cd531565e5fa2df1abfff1dfaee729"
Expand Down Expand Up @@ -22490,12 +22502,12 @@ minimatch@5.1.0, minimatch@^5.0.1, minimatch@^5.1.0:
dependencies:
brace-expansion "^2.0.1"

minimatch@^10.1.2:
version "10.1.2"
resolved "https://registry.yarnpkg.com/minimatch/-/minimatch-10.1.2.tgz#6c3f289f9de66d628fa3feb1842804396a43d81c"
integrity sha512-fu656aJ0n2kcXwsnwnv9g24tkU5uSmOlTjd6WyyaKm2Z+h1qmY6bAjrcaIxF/BslFqbZ8UBtbJi7KgQOZD2PTw==
minimatch@^10.1.2, minimatch@^10.2.1:
version "10.2.1"
resolved "https://registry.yarnpkg.com/minimatch/-/minimatch-10.2.1.tgz#9d82835834cdc85d5084dd055e9a4685fa56e5f0"
integrity sha512-MClCe8IL5nRRmawL6ib/eT4oLyeKMGCghibcDWK+J0hh0Q8kqSdia6BvbRMVk6mPa6WqUa5uR2oxt6C5jd533A==
dependencies:
"@isaacs/brace-expansion" "^5.0.1"
brace-expansion "^5.0.2"

minimatch@^7.4.1:
version "7.4.6"
Expand Down
Loading