Skip to content

Comments

fix(core): Fix error on langgraph resume#19354

Closed
jadengis wants to merge 2 commits intogetsentry:developfrom
jadengis:johndengis/fix-issue-on-resume
Closed

fix(core): Fix error on langgraph resume#19354
jadengis wants to merge 2 commits intogetsentry:developfrom
jadengis:johndengis/fix-issue-on-resume

Conversation

@jadengis
Copy link
Contributor

Before submitting a pull request, please take a look at our
Contributing guidelines and verify:

  • If you've added code that should be tested, please add tests.
  • Ensure your code lints and the test suite passes (yarn lint) & (yarn test).
  • Link an issue if there is one related to your pull request. If no issue is linked, one will be auto-generated and linked.

Closes #19353

@chargome chargome requested a review from RulaKhaled February 17, 2026 07:57
Copy link
Member

@nicohrubec nicohrubec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! Looks good to me, but we'll need to add some tests before merging. Should we take over?

@jadengis
Copy link
Contributor Author

@nicohrubec Feel free to take over! I would really appreciate the help. This has been burning me in production.

@jadengis
Copy link
Contributor Author

@nicohrubec Actually nvm I added a test and verified that it fails without the proposed fix. Let me know if this is acceptable. 🙏

@jadengis jadengis requested a review from nicohrubec February 18, 2026 02:45
Copy link
Member

@nicohrubec nicohrubec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have us test against the real API in this case. We have node integration tests to do that.
Specifically I would just add a graph.invoke(null) to this file:
https://github.com/getsentry/sentry-javascript/blob/develop/dev-packages/node-integration-tests/suites/tracing/langgraph/scenario.mjs

Then we need to update the test.ts in the same folder to check for the spans. Don't think we need the unit tests in this case

@nicohrubec
Copy link
Member

@jadengis I opened a PR with how I think we should test this so it fits nicely with the rest of our repo. I hope that's okay (tagged you as co-author so your contribution should still be displayed).

@nicohrubec
Copy link
Member

@jadengis Merged the fix! You are added as a co-author and mentioned in the changelog so I hope that's all good. Fix will go out with the next release 10.40.0. Closing this PR

@nicohrubec nicohrubec closed this Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

LangGraph Integration: TypeError: Cannot read properties of null (reading 'messages')

2 participants