fix(nuxt): Use options.rootDir instead of options.srcDir#19343
fix(nuxt): Use options.rootDir instead of options.srcDir#19343
options.rootDir instead of options.srcDir#19343Conversation
The wrapper is not needed, as it's just making the sure the types are correct. We can just use the type. For reference, this is the code for the wrapper: https://github.com/nitrojs/nitro/blob/f663e76df6b25610432c915f19d3cf7c5c19f72e/src/runtime/internal/plugin.ts Closes #19277
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
|
|
||
| buildStart() { | ||
| const configPath = createResolver(nitro.options.srcDir).resolve(`/${serverConfigFile}`); | ||
| const configPath = createResolver(nitro.options.rootDir).resolve(`/${serverConfigFile}`); |
There was a problem hiding this comment.
Fix lacks regression test coverage
Low Severity
This fix changes path resolution from nitro.options.srcDir to nitro.options.rootDir, but no unit, integration, or e2e test was added to verify the regression path. That leaves the behavior around serverConfigFile resolution unguarded against future regressions.
Triggered by project rule: PR Review Guidelines for Cursor Bot
There was a problem hiding this comment.
The E2E tests already test for that - if the server-side cannot be set up, it does not work.
Codecov Results 📊Generated by Codecov Action |
2 participants
Closes #19335