test(nuxt): Fix nuxt-4 dev E2E test#18737
Merged
Conversation
andreiborza
approved these changes
Jan 8, 2026
JPeer264
reviewed
Jan 8, 2026
| "@pinia/nuxt": "^0.5.5", | ||
| "@sentry/nuxt": "latest || *", | ||
| "nuxt": "^4.1.2" | ||
| "nitropack": "npm:nitropack-nightly@2.13.0-20260107-221335-d463e948", |
Member
There was a problem hiding this comment.
m: I think this line can be dropped and nuxt should go back to ^4.1.2
Member
Author
There was a problem hiding this comment.
whoops, I thought I excepted this from the commit. This was not on purpose
JPeer264
approved these changes
Jan 8, 2026
This was referenced Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was under the assumption that playwright will wait for the port
3030to start testing (as it is configured like this). But it seems like playwright already starts testing when only the temporary port3035is available.This fix runs the bash script first and only then starts playwright.
Closes #18728