feat(deps): bump @sentry/cli from 2.58.4 to 3.0.1#18607
feat(deps): bump @sentry/cli from 2.58.4 to 3.0.1#18607dependabot[bot] wants to merge 1 commit intodevelopfrom
Conversation
Bumps [@sentry/cli](https://github.com/getsentry/sentry-cli) from 2.58.4 to 3.0.1. - [Release notes](https://github.com/getsentry/sentry-cli/releases) - [Changelog](https://github.com/getsentry/sentry-cli/blob/master/CHANGELOG.md) - [Commits](getsentry/sentry-cli@2.58.4...3.0.1) --- updated-dependencies: - dependency-name: "@sentry/cli" dependency-version: 3.0.1 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
| "@opentelemetry/instrumentation": "^0.208.0", | ||
| "@opentelemetry/semantic-conventions": "^1.37.0", | ||
| "@remix-run/router": "1.x", | ||
| "@sentry/cli": "^2.58.2", | ||
| "@sentry/cli": "^3.0.1", | ||
| "@sentry/core": "10.32.1", | ||
| "@sentry/node": "10.32.1", | ||
| "@sentry/react": "10.32.1", |
There was a problem hiding this comment.
Bug: The upgrade to @sentry/cli v3.0.1 is a breaking change. The code still calls uploadSourceMaps with the removed options useArtifactBundle and live, which may cause a crash.
Severity: HIGH | Confidence: High
🔍 Detailed Analysis
The dependency @sentry/cli was upgraded to v3.0.1, a major version with breaking changes. Specifically, the useArtifactBundle and live options were removed from the sentry.releases.uploadSourceMaps method. However, scripts in packages/remix/scripts/createRelease.js and packages/react-router/src/vite/buildEnd/handleOnBuildEnd.ts continue to pass these now-removed options. Depending on how the new version of @sentry/cli handles unknown options, this could cause the release process to crash with a parameter validation error, preventing source maps from being uploaded.
💡 Suggested Fix
Remove the useArtifactBundle and live options from all calls to sentry.releases.uploadSourceMaps in packages/remix/scripts/createRelease.js and packages/react-router/src/vite/buildEnd/handleOnBuildEnd.ts. The new default behavior of @sentry/cli v3 matches the intended live: 'rejectOnError' behavior.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: packages/remix/package.json#L68-L74
Potential issue: The dependency `@sentry/cli` was upgraded to v3.0.1, a major version
with breaking changes. Specifically, the `useArtifactBundle` and `live` options were
removed from the `sentry.releases.uploadSourceMaps` method. However, scripts in
`packages/remix/scripts/createRelease.js` and
`packages/react-router/src/vite/buildEnd/handleOnBuildEnd.ts` continue to pass these
now-removed options. Depending on how the new version of `@sentry/cli` handles unknown
options, this could cause the release process to crash with a parameter validation
error, preventing source maps from being uploaded.
Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 7830019
|
We're not going to upgrade to v3 within this major (see #18518) |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps @sentry/cli from 2.58.4 to 3.0.1.
Release notes
Sourced from
@sentry/cli's releases.... (truncated)
Changelog
Sourced from
@sentry/cli's changelog.... (truncated)
Commits
76e7121release: 3.0.1fb9f3f9test(build): Make hash stable with version increases (#3047)81ece1cperf(preprod): Use zstd for zip compression (#3038)9988dbabuild(deps): bump getsentry/action-prepare-release from 1.6.4 to 1.6.6 (#3040)3b3f512build(deps): bump actions/upload-artifact from 5.0.0 to 6.0.0 (#3041)9668411build(deps): bump github/codeql-action from 4.31.7 to 4.31.8 (#3042)ab62bdebuild(deps): bump actions/download-artifact from 6.0.0 to 7.0.0 (#3039)775efe4docs(api): Remove confusing comment (#3036)aff647ebuild(npm): 🤖 Bump optional dependencies to 3.0.0c55333dMerge branch 'release/3.0.0'Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)