fix(core): Ensure logs past MAX_LOG_BUFFER_SIZE are not swallowed#18207
Merged
andreiborza merged 3 commits intodevelopfrom Nov 17, 2025
Merged
fix(core): Ensure logs past MAX_LOG_BUFFER_SIZE are not swallowed#18207andreiborza merged 3 commits intodevelopfrom
MAX_LOG_BUFFER_SIZE are not swallowed#18207andreiborza merged 3 commits intodevelopfrom
Conversation
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
MAX_LOG_BUFFER_SIZE are not swallowed
This was referenced Nov 14, 2025
Lms24
approved these changes
Nov 15, 2025
andreiborza
added a commit
that referenced
this pull request
Nov 17, 2025
andreiborza
added a commit
that referenced
this pull request
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like we swallowed the log that triggers a flush when
MAX_LOG_BUFFER_SIZEis surpassed.Test demonstrating issue: 5697b7d
Fix: f7a4d8b
Related metrics pr: #18212
v9 backport: #18213