[Gitflow] Merge master into develop#17875
Conversation
meta(changelog): Update changelog for 10.18.0
|
|
||
| ## 10.18.0 | ||
|
|
||
| ### Important Changes |
There was a problem hiding this comment.
Potential bug: The new pinoIntegration uses tracingChannel without a Node.js version check, causing a crash on unsupported Node.js versions when the integration is enabled.
-
Description: The new
pinoIntegrationimports and usestracingChannelfromnode:diagnostics_channelwithout a runtime check for Node.js version compatibility. ThetracingChannelAPI is only available in Node.js versions >=18.19.0. When this integration is enabled in an application running on an older, incompatible Node.js version (e.g., 18.18.0), the application will crash during SDK initialization due to the failed import. This behavior is not caught by tests, as they are conditionally configured to run only on Node.js 20 and above. -
Suggested fix: Add a runtime Node.js version check at the beginning of the
pinoIntegration. If the running Node.js version is older than a compatible version (e.g., <18.19.0), the integration should be disabled and a warning should be logged, preventing the application crash.
severity: 0.85, confidence: 0.95
Did we get this right? 👍 / 👎 to inform future reviews.
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Merge master branch into develop