Skip to content

Mark SentryEnvelope as not internal #4748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lcian merged 5 commits into from
Sep 26, 2025
Merged

Mark SentryEnvelope as not internal #4748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4459552
Mark classes needed for custom transport as not internal
lcian Sep 23, 2025
d20798f
Format code
getsentry-bot Sep 23, 2025
e82da51
improve
lcian Sep 25, 2025
7585ca7
changelog
lcian Sep 25, 2025
aa2ade1
mark all methods and ctors internal to not expose other classes
adinauer Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## Unreleased

### Improvements

- Mark `SentryEnvelope` as not internal ([#4748](https://github.com/getsentry/sentry-java/pull/4748))

## 8.22.0

### Features
Expand Down
9 changes: 8 additions & 1 deletion sentry/src/main/java/io/sentry/SentryEnvelope.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,29 +11,32 @@
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;

@ApiStatus.Internal
public final class SentryEnvelope {

// types: session_batch, session, event, attachment
// an envelope cannot have 2 events, but eg multiple sessions
private final @NotNull SentryEnvelopeHeader header;
private final @NotNull Iterable<SentryEnvelopeItem> items;

@ApiStatus.Internal
public @NotNull Iterable<SentryEnvelopeItem> getItems() {
return items;
}

@ApiStatus.Internal
public @NotNull SentryEnvelopeHeader getHeader() {
return header;
}

@ApiStatus.Internal
public SentryEnvelope(
final @NotNull SentryEnvelopeHeader header,
final @NotNull Iterable<SentryEnvelopeItem> items) {
this.header = Objects.requireNonNull(header, "SentryEnvelopeHeader is required.");
this.items = Objects.requireNonNull(items, "SentryEnvelope items are required.");
}

@ApiStatus.Internal
public SentryEnvelope(
final @Nullable SentryId eventId,
final @Nullable SdkVersion sdkVersion,
Expand All @@ -42,6 +45,7 @@ public SentryEnvelope(
this.items = Objects.requireNonNull(items, "SentryEnvelope items are required.");
}

@ApiStatus.Internal
public SentryEnvelope(
final @Nullable SentryId eventId,
final @Nullable SdkVersion sdkVersion,
Expand All @@ -54,6 +58,7 @@ public SentryEnvelope(
this.items = items;
}

@ApiStatus.Internal
public static @NotNull SentryEnvelope from(
final @NotNull ISerializer serializer,
final @NotNull Session session,
Expand All @@ -66,6 +71,7 @@ public SentryEnvelope(
null, sdkVersion, SentryEnvelopeItem.fromSession(serializer, session));
}

@ApiStatus.Internal
public static @NotNull SentryEnvelope from(
final @NotNull ISerializer serializer,
final @NotNull SentryBaseEvent event,
Expand All @@ -78,6 +84,7 @@ public SentryEnvelope(
event.getEventId(), sdkVersion, SentryEnvelopeItem.fromEvent(serializer, event));
}

@ApiStatus.Internal
public static @NotNull SentryEnvelope from(
final @NotNull ISerializer serializer,
final @NotNull ProfilingTraceData profilingTraceData,
Expand Down
Loading