Skip to content

feat(android-distribution): Use ProGuard UUID for build identification #4730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
runningcode wants to merge 1 commit into from
Closed

feat(android-distribution): Use ProGuard UUID for build identification #4730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions ...istribution/src/main/java/io/sentry/android/distribution/internal/DistributionInternal.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package io.sentry.android.distribution.internal

import android.content.Context
import io.sentry.Sentry
import io.sentry.android.distribution.DistributionOptions
import io.sentry.android.distribution.UpdateStatus

Expand All @@ -19,10 +20,22 @@ internal object DistributionInternal {
}

fun checkForUpdateBlocking(context: Context): UpdateStatus {
return UpdateStatus.Error("Implementation coming in future PR")
val buildIdentifier = Sentry.getCurrentScopes().options.proguardUuid
return if (!buildIdentifier.isNullOrEmpty()) {
UpdateStatus.Error(
"Build identifier from ProGuard UUID: $buildIdentifier. HTTP client and API models coming in future PRs."
)
} else {
UpdateStatus.Error(
"No ProGuard UUID found. Ensure sentry-debug-meta.properties contains io.sentry.ProguardUuids or set via manifest."
)
}
}

fun checkForUpdateAsync(context: Context, onResult: (UpdateStatus) -> Unit) {
throw NotImplementedError()
// For now, just call the blocking version and return the result
// In future PRs, this will be truly async
val result = checkForUpdateBlocking(context)
onResult(result)
}
}
Loading