Skip to content

Fix double init UI test #4723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stefanosiano merged 3 commits into from
Sep 15, 2025
Merged

Fix double init UI test #4723

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd2566b
updated changelog
stefanosiano Sep 12, 2025
59d3866
updated test to check for new options
stefanosiano Sep 12, 2025
b1b53b6
Merge branch 'main' into stefanosiano/fix/double-init-ui-test
stefanosiano Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 3 additions & 20 deletions ...tests/sentry-uitest-android/src/androidTest/java/io/sentry/uitest/android/SdkInitTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,20 +112,7 @@ class SdkInitTests : BaseUiTest() {

@Test
fun doubleInitDoesNotWait() {
relayIdlingResource.increment()
// Let's make the first request timeout
relay.addTimeoutResponse()

initSentry(true) { options: SentryAndroidOptions -> options.tracesSampleRate = 1.0 }

Sentry.startTransaction("beforeRestart", "emptyTransaction").finish()

// We want the SDK to start sending the event. If we don't wait, it's possible we don't send
// anything before the SDK is restarted
waitUntilIdle()

relayIdlingResource.increment()
relayIdlingResource.increment()
initSentry(true)

val beforeRestart = System.currentTimeMillis()
// We restart the SDK. This shouldn't block the main thread, but new options (e.g. profiling)
Expand All @@ -137,18 +124,14 @@ class SdkInitTests : BaseUiTest() {
val afterRestart = System.currentTimeMillis()
val restartMs = afterRestart - beforeRestart

relayIdlingResource.increment()
Sentry.startTransaction("afterRestart", "emptyTransaction").finish()

// We assert for less than 1 second just to account for slow devices in saucelabs or headless
// emulator
assertTrue(restartMs < 1000, "Expected less than 1000 ms for SDK restart. Got $restartMs ms")

relay.assert {
findEnvelope { assertEnvelopeTransaction(it.items.toList()).transaction == "beforeRestart" }
.assert {
it.assertTransaction()
// No profiling item, as in the first init it was not enabled
it.assertNoOtherItems()
}
findEnvelope { assertEnvelopeTransaction(it.items.toList()).transaction == "afterRestart" }
.assert {
it.assertTransaction()
Expand Down
Loading