Skip to content

Conversation

@lcian
Copy link
Member

@lcian lcian commented Sep 9, 2025

As this is needed in some cases and we now document it, removes the ApiStatus.INTERNAL annotation from these methods.

@lcian lcian marked this pull request as ready for review September 9, 2025 15:44
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 395.06 ms 442.18 ms 47.12 ms
Size 1.58 MiB 2.10 MiB 532.31 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b750b96 421.25 ms 444.09 ms 22.84 ms
674d437 355.28 ms 504.18 ms 148.90 ms
ee747ae 358.21 ms 389.41 ms 31.20 ms
ee747ae 396.82 ms 441.67 ms 44.86 ms
85d7417 347.21 ms 394.35 ms 47.15 ms
3699cd5 423.60 ms 495.52 ms 71.92 ms
ee747ae 386.94 ms 431.43 ms 44.49 ms
ee747ae 554.98 ms 611.50 ms 56.52 ms
ee747ae 382.73 ms 435.41 ms 52.68 ms
ee747ae 374.71 ms 455.18 ms 80.47 ms

App size

Revision Plain With Sentry Diff
b750b96 1.58 MiB 2.10 MiB 533.20 KiB
674d437 1.58 MiB 2.10 MiB 530.94 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
85d7417 1.58 MiB 2.10 MiB 533.44 KiB
3699cd5 1.58 MiB 2.10 MiB 533.45 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB

Previous results on branch: lcian/distinct-id-internal

Startup times

Revision Plain With Sentry Diff
e54ef44 362.67 ms 420.90 ms 58.23 ms

App size

Revision Plain With Sentry Diff
e54ef44 1.58 MiB 2.10 MiB 532.11 KiB

@lcian lcian enabled auto-merge (squash) September 10, 2025 09:41
@lcian lcian merged commit 479f8cc into main Sep 10, 2025
42 of 43 checks passed
@lcian lcian deleted the lcian/distinct-id-internal branch September 10, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants