Skip to content

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented Aug 25, 2025

📜 Description

Adapted http://github.com/baomidou/dynamic-datasource/blob/bae2677b83abad549e3ddf41b286749515360e7b/dynamic-datasource-spring/src/main/java/com/baomidou/dynamic/datasource/tx/LocalTxUtil.java to replace our implementation in UUIDGenerator with an Apache 2.0 based implementation.

💡 Motivation and Context

Previous code was GPL

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@adinauer adinauer marked this pull request as ready for review August 25, 2025 13:13
@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 355.14 ms 406.51 ms 51.37 ms
Size 1.58 MiB 2.10 MiB 533.45 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
ee747ae 358.21 ms 389.41 ms 31.20 ms
ee747ae 396.82 ms 441.67 ms 44.86 ms
ee747ae 405.43 ms 485.70 ms 80.28 ms
ee747ae 400.46 ms 423.61 ms 23.15 ms
ee747ae 357.79 ms 421.84 ms 64.05 ms
ee747ae 415.92 ms 470.15 ms 54.23 ms
ee747ae 374.71 ms 455.18 ms 80.47 ms
ee747ae 554.98 ms 611.50 ms 56.52 ms
ee747ae 386.94 ms 431.43 ms 44.49 ms
674d437 355.28 ms 504.18 ms 148.90 ms

App size

Revision Plain With Sentry Diff
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
ee747ae 1.58 MiB 2.10 MiB 530.95 KiB
674d437 1.58 MiB 2.10 MiB 530.94 KiB

Previous results on branch: 08-25-replace_uuidgenerator_implementation_with_apache_licensed_code

Startup times

Revision Plain With Sentry Diff
4b29197 402.96 ms 469.35 ms 66.40 ms
c51e13f 386.06 ms 446.32 ms 60.26 ms

App size

Revision Plain With Sentry Diff
4b29197 1.58 MiB 2.10 MiB 530.95 KiB
c51e13f 1.58 MiB 2.10 MiB 533.45 KiB

@adinauer adinauer merged commit 7314dbe into main Aug 27, 2025
45 of 46 checks passed
@adinauer adinauer deleted the 08-25-replace_uuidgenerator_implementation_with_apache_licensed_code branch August 27, 2025 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants