Skip to content

fix(android): Remove unused method #4585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markushi merged 2 commits into from
Jul 31, 2025
Merged

fix(android): Remove unused method #4585

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ab2c6e
fix(android): Remove unused method
markushi Jul 31, 2025
a735791
Update Changelog
markushi Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

- Cache network capabilities and status to reduce IPC calls ([#4560](https://github.com/getsentry/sentry-java/pull/4560))
- Deduplicate battery breadcrumbs ([#4561](https://github.com/getsentry/sentry-java/pull/4561))
- Remove unused method in ManifestMetadataReader ([#4585](https://github.com/getsentry/sentry-java/pull/4585))


## 8.18.0
Expand Down
17 changes: 0 additions & 17 deletions sentry-android-core/src/main/java/io/sentry/android/core/ManifestMetadataReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,23 +532,6 @@ private static boolean readBool(
return value;
}

@SuppressWarnings("deprecation")
private static @Nullable Boolean readBoolNullable(
final @NotNull Bundle metadata,
final @NotNull ILogger logger,
final @NotNull String key,
final @Nullable Boolean defaultValue) {
if (metadata.getSerializable(key) != null) {
final boolean nonNullDefault = defaultValue == null ? false : true;
final boolean bool = metadata.getBoolean(key, nonNullDefault);
logger.log(SentryLevel.DEBUG, key + " read: " + bool);
return bool;
} else {
logger.log(SentryLevel.DEBUG, key + " used default " + defaultValue);
return defaultValue;
}
}

private static @Nullable String readString(
final @NotNull Bundle metadata,
final @NotNull ILogger logger,
Expand Down
Loading