Skip to content

Do not use Sentry logging API if logs are disabled for JUL #4574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adinauer merged 3 commits into from
Jul 29, 2025
Merged

Do not use Sentry logging API if logs are disabled for JUL #4574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96eebfb
Do not use Sentry logging API if logs are disabled for JUL
adinauer Jul 29, 2025
a6c0e2a
changelog
adinauer Jul 29, 2025
4eced70
Merge branch 'main' into fix/reduce-noop-warnings-for-jul
adinauer Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
- Allow multiple UncaughtExceptionHandlerIntegrations to be active at the same time ([#4462](https://github.com/getsentry/sentry-java/pull/4462))
- Prevent repeated scroll target determination during a single scroll gesture ([#4557](https://github.com/getsentry/sentry-java/pull/4557))
- This should reduce the number of ANRs seen in `SentryGestureListener`
- Do not use Sentry logging API in JUL if logs are disabled ([#4574](https://github.com/getsentry/sentry-java/pull/4574))
- This was causing Sentry SDK to log warnings: "Sentry Log is disabled and this 'logger' call is a no-op."
- Do not use Sentry logging API in Log4j2 if logs are disabled ([#4573](https://github.com/getsentry/sentry-java/pull/4573))
- This was causing Sentry SDK to log warnings: "Sentry Log is disabled and this 'logger' call is a no-op."

Expand Down
3 changes: 2 additions & 1 deletion sentry-jul/src/main/java/io/sentry/jul/SentryHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ public void publish(final @NotNull LogRecord record) {
return;
}
try {
if (record.getLevel().intValue() >= minimumLevel.intValue()) {
if (ScopesAdapter.getInstance().getOptions().getLogs().isEnabled()
&& record.getLevel().intValue() >= minimumLevel.intValue()) {
captureLog(record);
}
if (record.getLevel().intValue() >= minimumEventLevel.intValue()) {
Expand Down
Loading