Skip to content

Conversation

@lcian
Copy link
Member

@lcian lcian commented Jul 14, 2025

📜 Description

Stacked on: #4552

  • Add an envrc so that the virtualenv is created automatically (if you have direnv and allow the dir) -- it is not strictly required to use direnv though
  • Add requirements.txt and use it in the GH workflow and makefile
  • Add test outputs to gitignore
  • Use a dataclass for the test run configs and improve the output a bit

My editor added some whitespace changes due to autoformatting.

#skip-changelog

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 417.52 ms 455.00 ms 37.48 ms
Size 1.58 MiB 2.09 MiB 519.28 KiB

Baseline results on branch: feat/e2e-console-app-samples

Startup times

Revision Plain With Sentry Diff
29f60d6 427.43 ms 465.10 ms 37.68 ms
ac946c9 500.50 ms 515.71 ms 15.21 ms
6e523f3 426.08 ms 444.80 ms 18.72 ms
97a4817 373.00 ms 418.60 ms 45.60 ms
2fe9357 447.49 ms 486.31 ms 38.82 ms

App size

Revision Plain With Sentry Diff
29f60d6 1.58 MiB 2.09 MiB 519.27 KiB
ac946c9 1.58 MiB 2.09 MiB 519.04 KiB
6e523f3 1.58 MiB 2.09 MiB 519.28 KiB
97a4817 1.58 MiB 2.09 MiB 519.05 KiB
2fe9357 1.58 MiB 2.09 MiB 519.04 KiB

Previous results on branch: lcian/ref/improve-e2e

Startup times

Revision Plain With Sentry Diff
a869d72 501.35 ms 560.96 ms 59.60 ms
21ce005 414.83 ms 465.98 ms 51.15 ms
56b50bc 431.61 ms 472.42 ms 40.80 ms

App size

Revision Plain With Sentry Diff
a869d72 1.58 MiB 2.09 MiB 519.27 KiB
21ce005 1.58 MiB 2.09 MiB 519.27 KiB
56b50bc 1.58 MiB 2.09 MiB 519.28 KiB

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, Thanks!

@lcian lcian marked this pull request as ready for review July 14, 2025 17:28
@lcian lcian merged commit 59e4f2b into feat/e2e-console-app-samples Jul 14, 2025
34 checks passed
@lcian lcian deleted the lcian/ref/improve-e2e branch July 14, 2025 17:46
adinauer added a commit that referenced this pull request Jul 18, 2025
* e2e tests for console app

* fix test failures by waiting for 10s after first try to find envelopes

* add system-test-runner.py script to replace bash scripts for running e2e / system tests

* use py script for ci, cleanup, makefile

* Format code

* remove bash scripts

* install requests module

* api

* fix gh script

* Improve setup for backend e2e tests (#4554)

---------

Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>
Co-authored-by: Lorenzo Cian <lorenzo.cian@sentry.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants