-
-
Notifications
You must be signed in to change notification settings - Fork 465
Bump OpenTelemetry SDK to 1.51.0, instrumentation to 2.17.0 and semconv to 1.34.0
#4532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1.51.0, instrumentation to 2.17.0 and semconv to 1.34.01.51.0, instrumentation to 2.17.0 and semconv to 1.34.0
|
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ccbb30a | 423.94 ms | 464.22 ms | 40.28 ms |
| 228dd89 | 449.13 ms | 465.16 ms | 16.04 ms |
| f2bb552 | 412.40 ms | 417.63 ms | 5.23 ms |
| 18428c8 | 452.84 ms | 490.71 ms | 37.88 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| ccbb30a | 1.58 MiB | 2.09 MiB | 518.94 KiB |
| 228dd89 | 1.58 MiB | 2.09 MiB | 518.90 KiB |
| f2bb552 | 1.58 MiB | 2.09 MiB | 518.90 KiB |
| 18428c8 | 1.58 MiB | 2.09 MiB | 518.93 KiB |
…y changing OpenTelemetry defaults) (#4537) * do not override span name if customized * Format code * log in case system property cannot be set * merge * changelog --------- Co-authored-by: Sentry Github Bot <bot+github-bot@sentry.io>
gradle/libs.versions.toml
Outdated
| otelInstrumentationAlpha = "2.17.0-alpha" | ||
| # check https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/dependencyManagement/build.gradle.kts#L49 for release version above to find a compatible version | ||
| otelSemanticConventions = "1.28.0-alpha" | ||
| otelSemanticConventions = "1.34.0-alpha" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this have to be alpha or could we use a normal version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch, I'll go through dependencies again to check which alpha versions have now been changed to non alpha.
Alpha used to mark the whole dependency as alpha. Previously there was no non alpha versions for some dependencies. This seems to have changed for at least semconv now: https://central.sonatype.com/artifact/io.opentelemetry.semconv/opentelemetry-semconv/versions
📜 Description
Bump:
opentelemetry-sdkto1.51.0opentelemetry-instrumentationto2.17.0opentelemetry-javaagentto2.17.0-
opentelemetry-semconvto1.34.0io.opentelemetry.semconv.SemanticAttributeshas been removed in1.30.0so we can no longer use it to read the deprecated attributes. This however should be fine since we bumped the instrumentation dependencies as well💡 Motivation and Context
Customers were reporting compile errors due to our outdated OTel version.
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps