Send Timber logs through Sentry Logs #4490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
stefanosiano
commented
Jun 13, 2025
| private val minEventLevel: SentryLevel, | ||
| private val minBreadcrumbLevel: SentryLevel | ||
| private val minBreadcrumbLevel: SentryLevel, | ||
| private val minLogsLevel: SentryLogLevel = SentryLogLevel.INFO |
Contributor
Author
There was a problem hiding this comment.
I added this default value so we don't introduce breaking changes
stefanosiano
requested review from
adinauer,
lcian,
markushi and
romtsn
as code owners
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dd482b5 | 405.70 ms | 418.73 ms | 13.03 ms |
| 07acfff | 386.38 ms | 412.92 ms | 26.54 ms |
| a3c7c46 | 399.67 ms | 444.53 ms | 44.86 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| dd482b5 | 1.58 MiB | 2.09 MiB | 518.90 KiB |
| 07acfff | 1.58 MiB | 2.08 MiB | 511.32 KiB |
| a3c7c46 | 1.58 MiB | 2.08 MiB | 511.32 KiB |
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md # sentry-android-core/src/test/java/io/sentry/android/core/InternalSentrySdkTest.kt # sentry-android-core/src/test/java/io/sentry/android/core/SentryLogcatAdapterTest.kt
# Conflicts: # sentry-android-timber/src/main/java/io/sentry/android/timber/SentryTimberIntegration.kt # sentry-android-timber/src/main/java/io/sentry/android/timber/SentryTimberTree.kt # sentry-android-timber/src/test/java/io/sentry/android/timber/SentryTimberIntegrationTest.kt # sentry-android-timber/src/test/java/io/sentry/android/timber/SentryTimberTreeTest.kt
adinauer
approved these changes
Jul 4, 2025
Member
adinauer
left a comment
adinauer
left a comment
There was a problem hiding this comment.
Mostly LGTM, just some questions.
sentry-android-timber/src/main/java/io/sentry/android/timber/SentryTimberTree.kt
Show resolved
Hide resolved
# Conflicts: # CHANGELOG.md # sentry-android-core/src/main/java/io/sentry/android/core/SentryLogcatAdapter.java # sentry-android-core/src/test/java/io/sentry/android/core/SentryLogcatAdapterTest.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Logs captured by Timber are now sent as Sentry Logs
💡 Motivation and Context
Closes #4407
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps