Skip to content

Use graphql-java v24 for Spring Boot 3.5 #4444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adinauer merged 1 commit into from
May 23, 2025
Merged

Use graphql-java v24 for Spring Boot 3.5 #4444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions buildSrc/src/main/java/Config.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ object Config {

val graphQlJava = "com.graphql-java:graphql-java:17.3"
val graphQlJava22 = "com.graphql-java:graphql-java:22.1"
val graphQlJavaNew = "com.graphql-java:graphql-java:24.0"
Copy link
Collaborator

@lbloder lbloder May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we go with major versions for the name like before? I.e. graphQlJava24?

Copy link
Member Author

@adinauer adinauer May 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about it but think it's better to skip the version in the name since we probably want to keep this aligned with Spring Boots required version in the future.

Or it would be even better to have Spring Boot take care of handling the version via its gradle plugin.


val quartz = "org.quartz-scheduler:quartz:2.3.0"

Expand Down
2 changes: 1 addition & 1 deletion sentry-spring-jakarta/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ dependencies {
testImplementation(Config.Libs.springBoot3StarterAop)
testImplementation(Config.Libs.springBoot3StarterGraphql)
testImplementation(Config.Libs.contextPropagation)
testImplementation(Config.Libs.graphQlJava22)
testImplementation(Config.Libs.graphQlJavaNew)
testImplementation(projects.sentryReactor)
}

Expand Down
Loading