Fork isolation scope for root spans in OtelSentrySpanProcessor instead of OtelSentryPropagator
#4434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adinauer
requested review from
lcian,
markushi,
romtsn and
stefanosiano
as code owners
Contributor
|
Member
|
Tested this with a library that doesn't have OTEL instrumentation (Pekko GRPC), using the OTEL API (OtelSentryPropagator) and things work as expected. |
Member
Author
|
Tested using our console OTel sample as well as Spring Boot 3 with Agent and Agentless. All of them work as expected. |
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fb0d103 | 449.29 ms | 474.78 ms | 25.49 ms |
| f498992 | 396.34 ms | 416.38 ms | 20.04 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fb0d103 | 1.58 MiB | 2.08 MiB | 510.85 KiB |
| f498992 | 1.58 MiB | 2.08 MiB | 510.85 KiB |
lcian
approved these changes
May 23, 2025
rbro112
pushed a commit
that referenced
this pull request
May 23, 2025
…ead of `OtelSentryPropagator` (#4434) * Fork isolation scope in SpanProcessor * improve creator strings * changelog * remove irrelevant tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Fork isolation scope for root spans in
OtelSentrySpanProcessorinstead ofOtelSentryPropagator.💡 Motivation and Context
Sentry.startTransaction(viaOtelSpanFactory) was also affected and did not fork isolation scope.sentry-traceheader can't be parsed we now still fork isolation scope💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps