Skip to content

Conversation

@runningcode
Copy link
Contributor

📜 Description

Version catalog adoption

#skip-changelog

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

okhttp = "4.9.2"
springTwo = "2.7.18"
springThree = "3.4.2"
targetSdk = "34"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There’s no way to have aliases or have targetSdk and compileSdk values reference each other.

@github-actions
Copy link
Contributor

github-actions bot commented May 21, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 450.92 ms 454.88 ms 3.96 ms
Size 1.58 MiB 2.08 MiB 510.82 KiB

Previous results on branch: no/version-catalog-6

Startup times

Revision Plain With Sentry Diff
54f9bc2 389.91 ms 401.67 ms 11.76 ms

App size

Revision Plain With Sentry Diff
54f9bc2 1.58 MiB 2.08 MiB 510.82 KiB

alias(libs.plugins.kotlin.spring)
id("war")
id(Config.BuildPlugins.gretty) version Config.BuildPlugins.grettyVersion
alias(libs.plugins.gretty)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to specify it in the root project with the version then?

Copy link
Contributor Author

@runningcode runningcode May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s a good point, i’ll do this.

It isn’t required but it helps maintain a single classpath for all projects. that should improve buildspeed if we have a single classpath. Our build, however, is a bit tricky since different subprojects use different versions of the same plugin (like spring) so the buildscript classpath cannot by synchronized 100% for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it looks like gretty depends on spring boot and since we don’t have spring boot in the root buildscript classpath, this causes conflicts.

@runningcode runningcode force-pushed the no/version-catalog-6 branch from 11b9191 to fb65146 Compare May 22, 2025 07:34
@runningcode runningcode enabled auto-merge (squash) May 22, 2025 07:52
@runningcode runningcode merged commit 0285c02 into main May 22, 2025
33 checks passed
@runningcode runningcode deleted the no/version-catalog-6 branch May 22, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants