-
-
Notifications
You must be signed in to change notification settings - Fork 465
More version catalog adoption #4428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| okhttp = "4.9.2" | ||
| springTwo = "2.7.18" | ||
| springThree = "3.4.2" | ||
| targetSdk = "34" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There’s no way to have aliases or have targetSdk and compileSdk values reference each other.
Performance metrics 🚀
|
| alias(libs.plugins.kotlin.spring) | ||
| id("war") | ||
| id(Config.BuildPlugins.gretty) version Config.BuildPlugins.grettyVersion | ||
| alias(libs.plugins.gretty) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to specify it in the root project with the version then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s a good point, i’ll do this.
It isn’t required but it helps maintain a single classpath for all projects. that should improve buildspeed if we have a single classpath. Our build, however, is a bit tricky since different subprojects use different versions of the same plugin (like spring) so the buildscript classpath cannot by synchronized 100% for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it looks like gretty depends on spring boot and since we don’t have spring boot in the root buildscript classpath, this causes conflicts.
11b9191 to
fb65146
Compare
📜 Description
Version catalog adoption
#skip-changelog
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps