Skip to content

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented May 13, 2025

#skip-changelog

📜 Description

Add more tests and handle Exception in String.format for logs

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 03abb01

@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 399.24 ms 418.87 ms 19.62 ms
Size 1.58 MiB 2.08 MiB 510.52 KiB

Previous results on branch: feat/logs-more-tests

Startup times

Revision Plain With Sentry Diff
8119fb2 386.41 ms 429.37 ms 42.95 ms
2cdd537 431.69 ms 498.31 ms 66.61 ms

App size

Revision Plain With Sentry Diff
8119fb2 1.58 MiB 2.08 MiB 509.65 KiB
2cdd537 1.58 MiB 2.08 MiB 509.66 KiB

Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a minor suggestion but it's fine to merge without it

Base automatically changed from feat/logs-manifest-option to main May 13, 2025 16:20
@adinauer adinauer enabled auto-merge (squash) May 13, 2025 16:21
@adinauer adinauer merged commit 2a4f3dd into main May 13, 2025
32 of 33 checks passed
@adinauer adinauer deleted the feat/logs-more-tests branch May 13, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants