Skip to content

Conversation

@adinauer
Copy link
Member

#skip-changelog

📜 Description

Remove logs.sample-rate again.

💡 Motivation and Context

We discussed internally that simply dropping random log messages likely leads to confusion and when reading the logs. For now beforeSendLog can be used instead.

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 80e5bb9

@adinauer adinauer mentioned this pull request May 12, 2025
7 tasks
Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 408.44 ms 459.24 ms 50.80 ms
Size 1.58 MiB 2.08 MiB 510.38 KiB

Base automatically changed from feat/separate-log-level-enum to main May 13, 2025 14:40
@adinauer adinauer enabled auto-merge (squash) May 13, 2025 14:43
@adinauer adinauer merged commit d08633d into main May 13, 2025
32 of 34 checks passed
@adinauer adinauer deleted the feat/remove-logs-sample-rate-option branch May 13, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants