Skip to content

Conversation

@adinauer
Copy link
Member

@adinauer adinauer commented May 12, 2025

#skip-changelog

📜 Description

Use a new enum SentryLogLevel for Logs.

💡 Motivation and Context

SentryLevel which is used by error events and breadcrumbs does not support level TRACE, therefore we need to use a separate enum for the log level of the Logs feature.

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2025

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 164f210

@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 381.92 ms 410.92 ms 29.00 ms
Size 1.58 MiB 2.08 MiB 510.41 KiB

Previous results on branch: feat/separate-log-level-enum

Startup times

Revision Plain With Sentry Diff
f5a3ee6 400.06 ms 414.27 ms 14.20 ms

App size

Revision Plain With Sentry Diff
f5a3ee6 1.58 MiB 2.08 MiB 509.68 KiB

Copy link
Member

@lcian lcian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adinauer adinauer linked an issue May 13, 2025 that may be closed by this pull request
Base automatically changed from feat/logs-e2e-tests to main May 13, 2025 14:23
@adinauer adinauer enabled auto-merge (squash) May 13, 2025 14:27
@adinauer adinauer merged commit 1e23fdc into main May 13, 2025
33 of 34 checks passed
@adinauer adinauer deleted the feat/separate-log-level-enum branch May 13, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add SentryLevel.TRACE

4 participants